Changeset 267385 in webkit

Timestamp:

Sep 21, 2020, 4:49:41 PM (6 years ago)

Author:

Andres Gonzalez

Message:

Make accessibility isolated tree a non-experimental feature.
​https://bugs.webkit.org/show_bug.cgi?id=216792

Reviewed by Chris Fleizach.

Promote accessibility isolated tree from an experimental feature to a
non-experimental one. This avoids the problem where a user can turn off
the feature through the Safari > Develop > Experimental Features submenu,
while the accessibility request are still coming on a secondary thread,
which leads to random crashes.

• Shared/WebPreferences.yaml:
• Shared/WebPreferencesExperimental.yaml:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferences.yaml (modified) (1 diff)
• Shared/WebPreferencesExperimental.yaml (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-21  Andres Gonzalez  <andresg_22@apple.com>
+
+        Make accessibility isolated tree a non-experimental feature.
+        https://bugs.webkit.org/show_bug.cgi?id=216792
+
+        Reviewed by Chris Fleizach.
+
+        Promote accessibility isolated tree from an experimental feature to a
+        non-experimental one. This avoids the problem where a user can turn off
+        the feature through the Safari > Develop > Experimental Features submenu,
+        while the accessibility request are still coming on a secondary thread,
+        which leads to random crashes.
+
+        * Shared/WebPreferences.yaml:
+        * Shared/WebPreferencesExperimental.yaml:
+
 2020-09-21  Basuke Suzuki  <basuke.suzuki@sony.com>
 

trunk/Source/WebKit/Shared/WebPreferences.yaml

@@ -988 +988 @@
   condition: ENABLE(PICTURE_IN_PICTURE_API)
 
+IsAccessibilityIsolatedTreeEnabled:
+  type: bool
+  defaultValue: false
+  humanReadableName: "Isolated Accessibility Tree Mode"
+  humanReadableDescription: "Enable an accessibility hierarchy for VoiceOver that can be accessed on a secondary thread for improved performance"
+  webcoreBinding: RuntimeEnabledFeatures
+  condition: ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+
 # Deprecated
 

trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml

@@ -496 +496 @@
   webcoreBinding: RuntimeEnabledFeatures
 
-IsAccessibilityIsolatedTreeEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Isolated Accessibility Tree Mode"
-  humanReadableDescription: "Enable an accessibility hierarchy for VoiceOver that can be accessed on a secondary thread for improved performance"
-  webcoreBinding: RuntimeEnabledFeatures
-  condition: ENABLE(ACCESSIBILITY_ISOLATED_TREE)
-
 WebShareFileAPIEnabled:
   type: bool