Changeset 267394 in webkit

Timestamp:

Sep 21, 2020, 9:44:47 PM (6 years ago)

Author:

timothy_horton@apple.com

Message:

paper.io ad close buttons cannot be iteracted with via trackpad on iPad
​https://bugs.webkit.org/show_bug.cgi?id=216812
<rdar://problem/68738585>

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isPaperIO):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(applicationIsKnownToIgnoreMouseEvents):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/RuntimeApplicationChecks.h (modified) (1 diff)
• WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-21  Tim Horton  <timothy_horton@apple.com>
+
+        paper.io ad close buttons cannot be iteracted with via trackpad on iPad
+        https://bugs.webkit.org/show_bug.cgi?id=216812
+        <rdar://problem/68738585>
+
+        Reviewed by Wenson Hsieh.
+
+        * platform/RuntimeApplicationChecks.h:
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::IOSApplication::isPaperIO):
+
 2020-09-21  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/RuntimeApplicationChecks.h

@@ -113 +113 @@
 WEBCORE_EXPORT bool isOKCupid();
 WEBCORE_EXPORT bool isJWLibrary();
+WEBCORE_EXPORT bool isPaperIO();
 
 } // IOSApplication

trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

@@ -429 +429 @@
 }
 
+bool IOSApplication::isPaperIO()
+{
+    static bool isPaperIO = applicationBundleIsEqualTo("io.voodoo.paperio"_s);
+    return isPaperIO;
+}
+
 #endif
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-21  Tim Horton  <timothy_horton@apple.com>
+
+        paper.io ad close buttons cannot be iteracted with via trackpad on iPad
+        https://bugs.webkit.org/show_bug.cgi?id=216812
+        <rdar://problem/68738585>
+
+        Reviewed by Wenson Hsieh.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (applicationIsKnownToIgnoreMouseEvents):
+
 2020-09-21  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -8572 +8572 @@
             || WebCore::IOSApplication::isNoggin() // <rdar://problem/64830335>
             || WebCore::IOSApplication::isOKCupid() // <rdar://problem/65698496>
-            || WebCore::IOSApplication::isJWLibrary()) { // <rdar://problem/68104852>
+            || WebCore::IOSApplication::isJWLibrary() // <rdar://problem/68104852>
+            || WebCore::IOSApplication::isPaperIO()) { // <rdar://problem/68738585>
             warningVersion = "14.2";
             return YES;