Changeset 267395 in webkit

Timestamp:

Sep 21, 2020, 9:56:42 PM (6 years ago)

Author:

Paulo Matos

Message:

Fix MIPS leai,leap when offset is nonzero
​https://bugs.webkit.org/show_bug.cgi?id=216772

Reviewed by Mark Lam.

Fix required by change from webkit#216685

• offlineasm/mips.rb:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• offlineasm/mips.rb (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-09-21  Paulo Matos  <pmatos@igalia.com>
+
+        Fix MIPS leai,leap when offset is nonzero
+        https://bugs.webkit.org/show_bug.cgi?id=216772
+
+        Reviewed by Mark Lam.
+
+        Fix required by change from webkit#216685
+        * offlineasm/mips.rb:
+
 2020-09-21  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/offlineasm/mips.rb

@@ -1051 +1051 @@
             if operands[0].is_a? LabelReference
                 labelRef = operands[0]
-                raise unless labelRef.offset == 0
-                $asm.puts "lw #{operands[1].mipsOperand}, %got(#{labelRef.asmLabel})($gp)"
+                if labelRef.offset > 0
+                    $asm.puts "li #{operands[1].mipsOperand}, #{labelRef.asmLabel}"
+                    $asm.puts "addu #{operands[1].mipsOperand}, #{operands[1].mipsOperand}, #{labelRef.offset}"
+                    $asm.puts "lw #{operands[1].mipsOperand}, %got(#{operands[1].mipsOperand})($gp)"
+                else
+                    $asm.puts "lw #{operands[1].mipsOperand}, %got(#{labelRef.asmLabel})($gp)"
+                end
             else
                 operands[0].mipsEmitLea(operands[1])