⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 267403 in webkit


Ignore:
Timestamp:
Sep 22, 2020, 5:10:58 AM (6 years ago)
Author:
youenn@apple.com
Message:

Move Media in GPU Process flag from internal to experimental
​https://bugs.webkit.org/show_bug.cgi?id=216473
<rdar://problem/69318786>

Reviewed by Eric Carlson.

Source/WebKit:

No change of behavior.

  • Shared/WebPreferencesExperimental.yaml:
  • Shared/WebPreferencesInternal.yaml:

Tools:

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
Disable Media in GPU Process flag and WebRTC codec experimental features by default.
This can be overriden by WebKitTestRunner options.

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r267400 r267403  
     12020-09-22  Youenn Fablet  <youenn@apple.com>
     2
     3        Move Media in GPU Process flag from internal to experimental
     4        https://bugs.webkit.org/show_bug.cgi?id=216473
     5        <rdar://problem/69318786>
     6
     7        Reviewed by Eric Carlson.
     8
     9        No change of behavior.
     10
     11        * Shared/WebPreferencesExperimental.yaml:
     12        * Shared/WebPreferencesInternal.yaml:
     13
    1142020-09-21  Youenn Fablet  <youenn@apple.com>
    215

  • trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml

    r267385 r267403  
    8686  humanReadableDescription: "Enable requestIdleCallback support"
    8787
     88UseGPUProcessForMedia:
     89  type: bool
     90  defaultValue: defaultUseGPUProcessForMedia()
     91  condition: ENABLE(GPU_PROCESS)
     92  humanReadableName: "Use GPU Process for media"
     93  humanReadableDescription: "Do all media loading and playback in the GPU Process"
     94  webcoreName: useGPUProcessForMedia
     95
    8896MediaRecorderEnabled:
    8997  type: bool

  • trunk/Source/WebKit/Shared/WebPreferencesInternal.yaml

    r267359 r267403  
    403403  humanReadableDescription: "Remove all non-cookie website data after just 30 seconds of no user interaction when Intelligent Tracking Prevention is enabled"
    404404
    405 UseGPUProcessForMedia:
    406   type: bool
    407   defaultValue: defaultUseGPUProcessForMedia()
    408   condition: ENABLE(GPU_PROCESS)
    409   humanReadableName: "Use GPU Process for media"
    410   humanReadableDescription: "Do all media loading and playback in the GPU Process"
    411   webcoreName: useGPUProcessForMedia
    412 
    413405LiveRangeSelectionEnabled:
    414406  type: bool

  • trunk/Tools/ChangeLog

    r267399 r267403  
     12020-09-22  Youenn Fablet  <youenn@apple.com>
     2
     3        Move Media in GPU Process flag from internal to experimental
     4        https://bugs.webkit.org/show_bug.cgi?id=216473
     5        <rdar://problem/69318786>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
     10        (parse_args):
     11        * WebKitTestRunner/TestController.cpp:
     12        (WTR::TestController::resetPreferencesToConsistentValues):
     13        Disable Media in GPU Process flag and WebRTC codec experimental features by default.
     14        This can be overriden by WebKitTestRunner options.
     15
    1162020-09-21  Adrian Perez de Castro  <aperez@igalia.com>
    217

  • trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

    r261629 r267403  
    382382        if not options.internal_feature:
    383383            options.internal_feature = []
    384         options.internal_feature.append('UseGPUProcessForMedia')
     384        options.experimental_feature.append('UseGPUProcessForMedia')
    385385        options.internal_feature.append('CaptureAudioInGPUProcessEnabled')
    386386        options.internal_feature.append('RenderCanvasInGPUProcessEnabled')

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r267284 r267403  
    838838
    839839    WKPreferencesEnableAllExperimentalFeatures(preferences);
     840    // All experimental features except:
     841    static WKStringRef webKitUseGPUProcessForMedia = WKStringCreateWithUTF8CString("UseGPUProcessForMedia");
     842    WKPreferencesSetExperimentalFeatureForKey(preferences, false, webKitUseGPUProcessForMedia);
     843    static WKStringRef webRTCPlatformCodecsInGPUProcessEnabled = WKStringCreateWithUTF8CString("WebRTCPlatformCodecsInGPUProcessEnabled");
     844    WKPreferencesSetExperimentalFeatureForKey(preferences, false, webRTCPlatformCodecsInGPUProcessEnabled);
    840845    for (const auto& experimentalFeature : options.experimentalFeatures)
    841846        WKPreferencesSetExperimentalFeatureForKey(preferences, experimentalFeature.value, toWK(experimentalFeature.key).get());
Note: See TracChangeset for help on using the changeset viewer.