Changeset 267413 in webkit

Timestamp:

Sep 22, 2020, 9:29:35 AM (6 years ago)

Author:

Chris Dumez

Message:

webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=216824

Reviewed by Darin Adler.

Source/WebCore:

If the time constant pass to AudioParam.setTargetAtTime() is 0, then insert a SetValue event in
the timeline instead of a SetTarget one, causing us to instantly jump to the target value. This
matches the Blink behavior.

No new tests, unskipped existing test.

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::setTargetAtTime):

LayoutTests:

Unskip test that is passing and no longer crashing.

• TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-22  Chris Dumez  <cdumez@apple.com>
+
+        webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=216824
+
+        Reviewed by Darin Adler.
+
+        Unskip test that is passing and no longer crashing.
+
+        * TestExpectations:
+
 2020-09-22  Lauro Moura  <lmoura@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -335 +335 @@
 # This WebAudio test is crashing in debug since its import from Blink.
 [ Debug ] webaudio/AudioBufferSource/audiobuffersource-playbackrate.html [ Crash ]
-[ Debug ] webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html [ Crash ]
 
 webkit.org/b/176929 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html [ Pass Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-22  Chris Dumez  <cdumez@apple.com>
+
+        webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=216824
+
+        Reviewed by Darin Adler.
+
+        If the time constant pass to AudioParam.setTargetAtTime() is 0, then insert a SetValue event in
+        the timeline instead of a SetTarget one, causing us to instantly jump to the target value. This
+        matches the Blink behavior.
+
+        No new tests, unskipped existing test.
+
+        * Modules/webaudio/AudioParamTimeline.cpp:
+        (WebCore::AudioParamTimeline::setTargetAtTime):
+
 2020-09-22  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp

@@ -95 +95 @@
 {
     auto locker = holdLock(m_eventsMutex);
+    // If timeConstant is 0, we instantly jump to the target value, so insert a SetValueEvent instead of SetTargetEvent.
+    if (!timeConstant)
+        return insertEvent(ParamEvent::createSetValueEvent(target, time));
     return insertEvent(ParamEvent::createSetTargetEvent(target, time, timeConstant));
 }