Changeset 267417 in webkit

Timestamp:

Sep 22, 2020, 9:53:31 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r267354): Only import resource module on Darwin
​https://bugs.webkit.org/show_bug.cgi?id=216823

Patch by Sam Sneddon <Sam Sneddon> on 2020-09-22
Reviewed by Darin Adler.

• web-platform-tests/tools/serve/serve.py:

Move the resource import to the local point behind the Darwin platform
test. This code is only run once per process initiation, hence it makes
no difference to have the import locally.

Location:

trunk/LayoutTests/imported/w3c

Files:

• ChangeLog (modified) (1 diff)
• web-platform-tests/tools/serve/serve.py (modified) (2 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2020-09-22  Sam Sneddon  <gsnedders@apple.com>
+
+        REGRESSION(r267354): Only import resource module on Darwin
+        https://bugs.webkit.org/show_bug.cgi?id=216823
+
+        Reviewed by Darin Adler.
+
+        * web-platform-tests/tools/serve/serve.py:
+        Move the resource import to the local point behind the Darwin platform
+        test. This code is only run once per process initiation, hence it makes
+        no difference to have the import locally.
+
 2020-09-22  Sam Weinig  <weinig@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/tools/serve/serve.py

@@ -9 +9 @@
 import os
 import platform
-import resource
 import signal
 import socket
@@ -422 +421 @@
             # on Darwin, NOFILE starts with a very low limit (256), so bump it up a little
             # by way of comparison, Debian starts with a limit of 1024, Windows 512
+            import resource  # local, as it only exists on Unix-like systems
             maxfilesperproc = int(subprocess.check_output(
                 ["sysctl", "-n", "kern.maxfilesperproc"]