Changeset 267441 in webkit

Timestamp:

Sep 22, 2020, 3:26:39 PM (6 years ago)

Author:

Keith Rollin

Message:

Refactor build rules in Makefiles and Makefile.shared
​https://bugs.webkit.org/show_bug.cgi?id=216806
<rdar://problem/69332316>

Reviewed by David Kilzer.

Build fix: Previous change for this bug broke the ability to perform a
build with just make, due to that code path invoking
set-webkit-configuration with no parameters, which causes that
script to error-out.

• Makefile.shared:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Makefile.shared (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2020-09-22  Keith Rollin  <krollin@apple.com>
+
+        Refactor build rules in Makefiles and Makefile.shared
+        https://bugs.webkit.org/show_bug.cgi?id=216806
+        <rdar://problem/69332316>
+
+        Reviewed by David Kilzer.
+
+        Build fix: Previous change for this bug broke the ability to perform a
+        build with just `make`, due to that code path invoking
+        `set-webkit-configuration` with no parameters, which causes that
+        script to error-out.
+
+        * Makefile.shared:
+
 2020-09-22  Keith Rollin  <krollin@apple.com>
 

trunk/Makefile.shared

@@ -105 +105 @@
 
 all:
+ifneq (,$(strip $(ASAN_OPTION) $(TSAN_OPTION) $(WK_LTO_OPTION)))
         @$(call set_webkit_configuration,)
+endif
         @$(call invoke_xcode,,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')