Changeset 267447 in webkit

Timestamp:

Sep 22, 2020, 5:04:52 PM (6 years ago)

Author:

aakash_jain@apple.com

Message:

Limit number of emails to send for flaky and pre-existing JSC test failures
​https://bugs.webkit.org/show_bug.cgi?id=216857

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeJSCTestsResults.start):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -1731 +1731 @@
         flaky_stress_failures = first_run_stress_failures.union(second_run_stress_failures) - first_run_stress_failures.intersection(second_run_stress_failures)
         flaky_binary_failures = first_run_binary_failures.union(second_run_binary_failures) - first_run_binary_failures.intersection(second_run_binary_failures)
-        flaky_failures = list(flaky_binary_failures) + list(flaky_stress_failures)
+        flaky_failures = (list(flaky_binary_failures) + list(flaky_stress_failures))[:self.NUM_FAILURES_TO_DISPLAY]
         flaky_failures_string = ', '.join(flaky_failures)
 
@@ -1770 +1770 @@
             if clean_tree_failures:
                 message = 'Found {} pre-existing JSC test failure{}: {}'.format(len(clean_tree_failures), pluralSuffix, clean_tree_failures_string)
-                for clean_tree_failure in clean_tree_failures:
+                for clean_tree_failure in clean_tree_failures[:self.NUM_FAILURES_TO_DISPLAY]:
                     self.send_email_for_pre_existing_failure(clean_tree_failure)
             if len(clean_tree_failures) > self.NUM_FAILURES_TO_DISPLAY:

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-22  Aakash Jain  <aakash_jain@apple.com>
+
+        Limit number of emails to send for flaky and pre-existing JSC test failures
+        https://bugs.webkit.org/show_bug.cgi?id=216857
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeJSCTestsResults.start):
+
 2020-09-22  Sihui Liu  <sihui_liu@apple.com>