Changeset 267454 in webkit

Timestamp:

Sep 22, 2020, 6:57:35 PM (6 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Enable Intl.DateTimeFormat dayPeriod
​https://bugs.webkit.org/show_bug.cgi?id=216845

Reviewed by Mark Lam.

JSTests:

• stress/intl-datetimeformat.js:

Source/JavaScriptCore:

Since we already have consensus, let's enable it.
For now, we keep this flag since it is possible that something
happens before the change is integrated into the spec.

• runtime/OptionsList.h:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/intl-datetimeformat.js (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/OptionsList.h (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2020-09-22  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Enable Intl.DateTimeFormat dayPeriod
+        https://bugs.webkit.org/show_bug.cgi?id=216845
+
+        Reviewed by Mark Lam.
+
+        * stress/intl-datetimeformat.js:
+
 2020-09-22  HyeockJin Kim  <kherootz@gmail.com>
 

trunk/JSTests/stress/intl-datetimeformat.js

@@ -698 +698 @@
         let dtf = new Intl.DateTimeFormat("en", {hour: "numeric", minute: "numeric", second: "numeric", fractionalSecondDigits: 1});
         shouldBe(dtf.format(t), `7:00:23.1 AM`);
-        shouldBe(JSON.stringify(dtf.resolvedOptions()), `{"locale":"en","calendar":"gregory","numberingSystem":"latn","timeZone":"America/Los_Angeles","hourCycle":"h12","hour12":true,"hour":"numeric","minute":"2-digit","second":"2-digit","fractionalSecondDigits":1}`);
+        shouldBe(JSON.stringify(dtf.resolvedOptions()), `{"locale":"en","calendar":"gregory","numberingSystem":"latn","timeZone":"America/Los_Angeles","hourCycle":"h12","hour12":true,"dayPeriod":"short","hour":"numeric","minute":"2-digit","second":"2-digit","fractionalSecondDigits":1}`);
     }
     shouldThrow(() => {

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-09-22  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Enable Intl.DateTimeFormat dayPeriod
+        https://bugs.webkit.org/show_bug.cgi?id=216845
+
+        Reviewed by Mark Lam.
+
+        Since we already have consensus, let's enable it.
+        For now, we keep this flag since it is possible that something
+        happens before the change is integrated into the spec.
+
+        * runtime/OptionsList.h:
+
 2020-09-22  HyeockJin Kim  <kherootz@gmail.com>
 

trunk/Source/JavaScriptCore/runtime/OptionsList.h

@@ -490 +490 @@
     /* FIXME: We should make sure finalizers don't run for detached windows before enabling WeakRefs by default. https://bugs.webkit.org/show_bug.cgi?id=214508 */ \
     v(Bool, useWeakRefs, false, Normal, "Expose the WeakRef constructor.") \
-    v(Bool, useIntlDateTimeFormatDayPeriod, false, Normal, "Expose the Intl.DateTimeFormat dayPeriod feature.") \
+    v(Bool, useIntlDateTimeFormatDayPeriod, true, Normal, "Expose the Intl.DateTimeFormat dayPeriod feature.") \
     v(Bool, useArrayAllocationProfiling, true, Normal, "If true, we will use our normal array allocation profiling. If false, the allocation profile will always claim to be undecided.") \
     v(Bool, forcePolyProto, false, Normal, "If true, create_this will always create an object with a poly proto structure.") \