Changeset 267457 in webkit

Timestamp:

Sep 22, 2020, 8:36:13 PM (6 years ago)

Author:

Lauro Moura

Message:

[GTK] REGRESSION(r267329): imported/blink/editing/undo/crash-redo-with-iframes.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=216778

Reviewed by Darin Adler.

Covered by existing tests.

• editing/markup.cpp:

(WebCore::serializePreservingVisualAppearanceInternal): Return early
also for "negative" ranges to avoid hitting an assertion inside
serializeNodes, as suggested by Darin.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/markup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-22  Lauro Moura  <lmoura@igalia.com>
+
+        [GTK] REGRESSION(r267329): imported/blink/editing/undo/crash-redo-with-iframes.html is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=216778
+
+        Reviewed by Darin Adler.
+
+        Covered by existing tests.
+
+        * editing/markup.cpp:
+        (WebCore::serializePreservingVisualAppearanceInternal): Return early
+        also for "negative" ranges to avoid hitting an assertion inside
+        serializeNodes, as suggested by Darin.
+
 2020-09-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/editing/markup.cpp

@@ -840 +840 @@
     static NeverDestroyed<const String> interchangeNewlineString(MAKE_STATIC_STRING_IMPL("<br class=\"" AppleInterchangeNewline "\">"));
 
-    if (start == end)
+    if (!(start < end))
         return emptyString();