Changeset 267458 in webkit

Timestamp:

Sep 22, 2020, 8:38:17 PM (6 years ago)

Author:

Keith Rollin

Message:

Unify debug and release target aliases
​https://bugs.webkit.org/show_bug.cgi?id=216863
<rdar://problem/69407746>

Reviewed by Tim Horton.

All Makefiles have "debug", "d", "release", and "r" for build
targets. Others -- but not all -- also include "dev", "develop",
"development", "dep", "deploy", and "deployment". Because of this
inconsistency, trying to use those additional targets didn't work. It
looks like all Makefiles used to support all of those targets, but
some got dropped along the way. For instance, the top-level Makefile
and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
looks like WebKitLibraries/Makefile never had them. Given that those
additional targets don't work, it seems like no one uses them, so
let's remove them completely.

.:

• Makefile.shared:

Source/ThirdParty:

• Makefile:

Tools:

• Makefile:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Makefile.shared (modified) (1 diff)
• Source/ThirdParty/ChangeLog (modified) (1 diff)
• Source/ThirdParty/Makefile (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Makefile (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2020-09-22  Keith Rollin  <krollin@apple.com>
+
+        Unify debug and release target aliases
+        https://bugs.webkit.org/show_bug.cgi?id=216863
+        <rdar://problem/69407746>
+
+        Reviewed by Tim Horton.
+
+        All Makefiles have "debug", "d", "release", and "r" for build
+        targets. Others -- but not all -- also include "dev", "develop",
+        "development", "dep", "deploy", and "deployment". Because of this
+        inconsistency, trying to use those additional targets didn't work. It
+        looks like all Makefiles used to support all of those targets, but
+        some got dropped along the way. For instance, the top-level Makefile
+        and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
+        looks like WebKitLibraries/Makefile never had them. Given that those
+        additional targets don't work, it seems like no one uses them, so
+        let's remove them completely.
+
+        * Makefile.shared:
+
 2020-09-22  Keith Rollin  <krollin@apple.com>
 

trunk/Makefile.shared

@@ -110 +110 @@
         @$(call invoke_xcode,,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')
 
-debug d development dev develop: force
+debug d: force
         @$(call set_webkit_configuration,--debug)
         @$(call invoke_xcode,,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')
 
-release r deployment dep deploy: force
+release r: force
         @$(call set_webkit_configuration,--release)
         @$(call invoke_xcode,,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')

trunk/Source/ThirdParty/ChangeLog

@@ +1 @@
+2020-09-22  Keith Rollin  <krollin@apple.com>
+
+        Unify debug and release target aliases
+        https://bugs.webkit.org/show_bug.cgi?id=216863
+        <rdar://problem/69407746>
+
+        Reviewed by Tim Horton.
+
+        All Makefiles have "debug", "d", "release", and "r" for build
+        targets. Others -- but not all -- also include "dev", "develop",
+        "development", "dep", "deploy", and "deployment". Because of this
+        inconsistency, trying to use those additional targets didn't work. It
+        looks like all Makefiles used to support all of those targets, but
+        some got dropped along the way. For instance, the top-level Makefile
+        and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
+        looks like WebKitLibraries/Makefile never had them. Given that those
+        additional targets don't work, it seems like no one uses them, so
+        let's remove them completely.
+
+        * Makefile:
+
 2020-09-22  Keith Rollin  <krollin@apple.com>
 

trunk/Source/ThirdParty/Makefile

@@ -36 +36 @@
         @$(build_target_for_each_module)
 
-debug d development dev develop:
+debug d:
         @$(build_target_for_each_module)
 
-release r deployment dep deploy:
+release r:
         @$(build_target_for_each_module)
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-22  Keith Rollin  <krollin@apple.com>
+
+        Unify debug and release target aliases
+        https://bugs.webkit.org/show_bug.cgi?id=216863
+        <rdar://problem/69407746>
+
+        Reviewed by Tim Horton.
+
+        All Makefiles have "debug", "d", "release", and "r" for build
+        targets. Others -- but not all -- also include "dev", "develop",
+        "development", "dep", "deploy", and "deployment". Because of this
+        inconsistency, trying to use those additional targets didn't work. It
+        looks like all Makefiles used to support all of those targets, but
+        some got dropped along the way. For instance, the top-level Makefile
+        and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
+        looks like WebKitLibraries/Makefile never had them. Given that those
+        additional targets don't work, it seems like no one uses them, so
+        let's remove them completely.
+
+        * Makefile:
+
 2020-09-22  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/Makefile

@@ -32 +32 @@
         @$(build_target_for_each_module)
 
-debug d development dev develop:
+debug d:
         @$(build_target_for_each_module)
 
-release r deployment dep deploy:
+release r:
         @$(build_target_for_each_module)