Changeset 267464 in webkit

Timestamp:

Sep 22, 2020, 9:47:42 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Change InspectorAnimationAgent->startTracking to not error on repeated calls
​https://bugs.webkit.org/show_bug.cgi?id=216385

Patch by Patrick Angle <Patrick Angle> on 2020-09-22
Reviewed by Devin Rousso.

InpsectorAnimationAgent now mirrors the behavior of other timeline agents by no longer returning an error on a
repeated invocation of startTracking.

• inspector/agents/InspectorAnimationAgent.cpp:

(WebCore::InspectorAnimationAgent::startTracking):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/agents/InspectorAnimationAgent.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-22  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Change `InspectorAnimationAgent->startTracking` to not error on repeated calls
+        https://bugs.webkit.org/show_bug.cgi?id=216385
+
+        Reviewed by Devin Rousso.
+
+        InpsectorAnimationAgent now mirrors the behavior of other timeline agents by no longer returning an error on a
+        repeated invocation of `startTracking`.
+
+        * inspector/agents/InspectorAnimationAgent.cpp:
+        (WebCore::InspectorAnimationAgent::startTracking):
+
 2020-09-22  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp

@@ -341 +341 @@
 {
     if (m_instrumentingAgents.trackingAnimationAgent() == this)
-        return makeUnexpected("Animation domain already tracking"_s);
+        return { };
 
     m_instrumentingAgents.setTrackingAnimationAgent(this);