Changeset 267465 in webkit

Timestamp:

Sep 23, 2020, 12:57:26 AM (6 years ago)

Author:

Alan Bujtas

Message:

[LFC][IFC] Remove redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled from Line::Run::hasTrailingLetterSpacing
​https://bugs.webkit.org/show_bug.cgi?id=216867

Reviewed by Simon Fraser.

This codepath is only triggered when Line::TrimmableTrailingContent has a partially trimmable run.
However we don't add such runs unless m_shouldIgnoreTrailingLetterSpacing is false (which is already based on the RuntimeEnabledFeatures flag).

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::Run::hasTrailingLetterSpacing const):
(WebCore::Layout::Line::Run::trailingLetterSpacing const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/inlineformatting/InlineLine.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-23  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] Remove redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled from Line::Run::hasTrailingLetterSpacing
+        https://bugs.webkit.org/show_bug.cgi?id=216867
+
+        Reviewed by Simon Fraser.
+
+        This codepath is only triggered when Line::TrimmableTrailingContent has a partially trimmable run.
+        However we don't add such runs unless m_shouldIgnoreTrailingLetterSpacing is false (which is already based on the RuntimeEnabledFeatures flag).
+
+        * layout/inlineformatting/InlineLine.cpp:
+        (WebCore::Layout::Line::Run::hasTrailingLetterSpacing const):
+        (WebCore::Layout::Line::Run::trailingLetterSpacing const):
+
 2020-09-22  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp

@@ -498 +498 @@
 bool Line::Run::hasTrailingLetterSpacing() const
 {
-    // Complex line layout does not keep track of trailing letter spacing.
-    if (RuntimeEnabledFeatures::sharedFeatures().layoutFormattingContextIntegrationEnabled())
-        return false;
     return !hasTrailingWhitespace() && style().letterSpacing() > 0;
 }
@@ -507 +504 @@
 {
     if (!hasTrailingLetterSpacing())
-        return 0_lu;
+        return { };
     return InlineLayoutUnit { style().letterSpacing() };
 }