⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 267474 in webkit


Ignore:
Timestamp:
Sep 23, 2020, 7:44:24 AM (6 years ago)
Author:
Philippe Normand
Message:

media/can-play-av1.html is not spec compliant
​https://bugs.webkit.org/show_bug.cgi?id=216873

Reviewed by Eric Carlson.

Source/WebCore:

  • platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::initialize): Add the "av1" codec in the codecs mapping.

LayoutTests:

  • media/media-can-play-av1-expected.txt: Update baseline.
  • media/media-can-play-av1.html: Update test and add another few testing invalid codecs.
  • platform/glib/TestExpectations: Unflag passing test.
  • platform/mac/media/media-can-play-av1-expected.txt: Added. This test is expected to fail on mac.
Location:
trunk
Files:
1 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r267472 r267474  
     12020-09-23  Philippe Normand  <pnormand@igalia.com>
     2
     3        media/can-play-av1.html is not spec compliant
     4        https://bugs.webkit.org/show_bug.cgi?id=216873
     5
     6        Reviewed by Eric Carlson.
     7
     8        * media/media-can-play-av1-expected.txt: Update baseline.
     9        * media/media-can-play-av1.html: Update test and add another few testing invalid codecs.
     10        * platform/glib/TestExpectations: Unflag passing test.
     11        * platform/mac/media/media-can-play-av1-expected.txt: Added. This test is expected to fail on mac.
     12
    1132020-09-23  Youenn Fablet  <youenn@apple.com>
    214

  • trunk/LayoutTests/media/media-can-play-av1-expected.txt

    r264734 r267474  
    44These tests may be expected to fail if the WebKit port does not support the format.
    55
    6 EXPECTED (video.canPlayType('video/mp4; codecs=av1') == '') OK
    7 EXPECTED (video.canPlayType('video/webm; codecs=av1') == '') OK
    8 EXPECTED (video.canPlayType('video/mp4; codecs=av01.0.04M.08') == '') OK
    9 EXPECTED (video.canPlayType('video/webm; codecs=av01.0.04M.08') == '') OK
     6EXPECTED (video.canPlayType('video/mp4; codecs=av1') == 'probably') OK
     7EXPECTED (video.canPlayType('video/webm; codecs=av1') == 'probably') OK
     8EXPECTED (video.canPlayType('video/mp4; codecs=av01.0.04M.08') == 'probably') OK
     9EXPECTED (video.canPlayType('video/webm; codecs=av01.0.04M.08') == 'probably') OK
     10EXPECTED (video.canPlayType('video/webm; codecs=aaaav1') == '') OK
     11EXPECTED (video.canPlayType('video/mp4; codecs=bbbav1') == '') OK
    1012END OF TEST
    1113

  • trunk/LayoutTests/media/media-can-play-av1.html

    r264734 r267474  
    77             video = mediaElement = document.getElementsByTagName('video')[0];
    88
    9              testExpected("video.canPlayType('video/mp4; codecs=av1')", "");
    10              testExpected("video.canPlayType('video/webm; codecs=av1')", "");
     9             testExpected("video.canPlayType('video/mp4; codecs=av1')", "probably");
     10             testExpected("video.canPlayType('video/webm; codecs=av1')", "probably");
    1111
    12              testExpected("video.canPlayType('video/mp4; codecs=av01.0.04M.08')", "");
    13              testExpected("video.canPlayType('video/webm; codecs=av01.0.04M.08')", "");
     12             testExpected("video.canPlayType('video/mp4; codecs=av01.0.04M.08')", "probably");
     13             testExpected("video.canPlayType('video/webm; codecs=av01.0.04M.08')", "probably");
    1414
     15             testExpected("video.canPlayType('video/webm; codecs=aaaav1')", "");
     16             testExpected("video.canPlayType('video/mp4; codecs=bbbav1')", "");
    1517             endTest();
    1618         }

  • trunk/LayoutTests/platform/glib/TestExpectations

    r267471 r267474  
    262262
    263263webkit.org/b/214031 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video-poster-shown-preload-auto.html [ ImageOnlyFailure ]
    264 
    265 webkit.org/b/207547 media/media-can-play-av1.html [ Failure ]
    266264
    267265webkit.org/b/214422 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct.html [ Failure Pass ]

  • trunk/Source/WebCore/ChangeLog

    r267472 r267474  
     12020-09-23  Philippe Normand  <pnormand@igalia.com>
     2
     3        media/can-play-av1.html is not spec compliant
     4        https://bugs.webkit.org/show_bug.cgi?id=216873
     5
     6        Reviewed by Eric Carlson.
     7
     8        * platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
     9        (WebCore::GStreamerRegistryScanner::initialize): Add the "av1" codec in the codecs mapping.
     10
    1112020-09-23  Youenn Fablet  <youenn@apple.com>
    212

  • trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

    r267335 r267474  
    211211    if ((matroskaSupported || isContainerTypeSupported("video/mp4")) && hasElementForMediaType(m_videoDecoderFactories, "video/x-av1", false, makeOptional(WTFMove(av1DecodersBlacklist)))) {
    212212        m_codecMap.add(AtomString("av01*"), false);
     213        m_codecMap.add(AtomString("av1"), false);
    213214        m_codecMap.add(AtomString("x-av1"), false);
    214215    }
Note: See TracChangeset for help on using the changeset viewer.