Changeset 267479 in webkit

Timestamp:

Sep 23, 2020, 9:03:59 AM (6 years ago)

Author:

Truitt Savell

Message:

Unreviewed, reverting r267403.

Caused 50+ Crashes on iOS Debug

Reverted changeset:

"Move Media in GPU Process flag from internal to experimental"
​https://bugs.webkit.org/show_bug.cgi?id=216473
​https://trac.webkit.org/changeset/267403

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Shared/WebPreferencesExperimental.yaml (modified) (1 diff)
• Source/WebKit/Shared/WebPreferencesInternal.yaml (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (modified) (1 diff)
• Tools/WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-23  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, reverting r267403.
+
+        Caused 50+ Crashes on iOS Debug
+
+        Reverted changeset:
+
+        "Move Media in GPU Process flag from internal to experimental"
+        https://bugs.webkit.org/show_bug.cgi?id=216473
+        https://trac.webkit.org/changeset/267403
+
 2020-09-23  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml

@@ -86 +86 @@
   humanReadableDescription: "Enable requestIdleCallback support"
 
-UseGPUProcessForMedia:
-  type: bool
-  defaultValue: defaultUseGPUProcessForMedia()
-  condition: ENABLE(GPU_PROCESS)
-  humanReadableName: "Use GPU Process for media"
-  humanReadableDescription: "Do all media loading and playback in the GPU Process"
-  webcoreName: useGPUProcessForMedia
-
 MediaRecorderEnabled:
   type: bool

trunk/Source/WebKit/Shared/WebPreferencesInternal.yaml

@@ -418 +418 @@
   humanReadableDescription: "Remove all non-cookie website data after just 30 seconds of no user interaction when Intelligent Tracking Prevention is enabled"
 
+UseGPUProcessForMedia:
+  type: bool
+  defaultValue: defaultUseGPUProcessForMedia()
+  condition: ENABLE(GPU_PROCESS)
+  humanReadableName: "Use GPU Process for media"
+  humanReadableDescription: "Do all media loading and playback in the GPU Process"
+  webcoreName: useGPUProcessForMedia
+
 LiveRangeSelectionEnabled:
   type: bool

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-23  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, reverting r267403.
+
+        Caused 50+ Crashes on iOS Debug
+
+        Reverted changeset:
+
+        "Move Media in GPU Process flag from internal to experimental"
+        https://bugs.webkit.org/show_bug.cgi?id=216473
+        https://trac.webkit.org/changeset/267403
+
 2020-09-23  Lauro Moura  <lmoura@igalia.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -382 +382 @@
         if not options.internal_feature:
             options.internal_feature = []
-        options.experimental_feature.append('UseGPUProcessForMedia')
+        options.internal_feature.append('UseGPUProcessForMedia')
         options.internal_feature.append('CaptureAudioInGPUProcessEnabled')
         options.internal_feature.append('RenderCanvasInGPUProcessEnabled')

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -838 +838 @@
 
     WKPreferencesEnableAllExperimentalFeatures(preferences);
-    // All experimental features except:
-    static WKStringRef webKitUseGPUProcessForMedia = WKStringCreateWithUTF8CString("UseGPUProcessForMedia");
-    WKPreferencesSetExperimentalFeatureForKey(preferences, false, webKitUseGPUProcessForMedia);
-    static WKStringRef webRTCPlatformCodecsInGPUProcessEnabled = WKStringCreateWithUTF8CString("WebRTCPlatformCodecsInGPUProcessEnabled");
-    WKPreferencesSetExperimentalFeatureForKey(preferences, false, webRTCPlatformCodecsInGPUProcessEnabled);
     for (const auto& experimentalFeature : options.experimentalFeatures)
         WKPreferencesSetExperimentalFeatureForKey(preferences, experimentalFeature.value, toWK(experimentalFeature.key).get());