Changeset 267486 in webkit

Timestamp:

Sep 23, 2020, 10:07:18 AM (6 years ago)

Author:

Chris Dumez

Message:

webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=216827

Reviewed by Darin Adler.

Source/WebCore:

AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping() would hit an assertion inside
finish() because finish() was already called earlier when calling updateSchedulingInfo().
updateSchedulingInfo() already takes care of calling finish() when we're done playing.
Address the issue by only calling finish() if hasFinished() returns false.

No new tests, unskipped existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping):

LayoutTests:

Unskip test that is no longer crashing.

• TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-23  Chris Dumez  <cdumez@apple.com>
+
+        webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=216827
+
+        Reviewed by Darin Adler.
+
+        Unskip test that is no longer crashing.
+
+        * TestExpectations:
+
 2020-09-23  Philippe Normand  <pnormand@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -333 +333 @@
 webaudio/AudioBufferSource/audiobuffersource-detune-modulation.html [ Pass Failure ]
 webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html [ Pass Failure ]
-
-# This WebAudio test is crashing in debug since its import from Blink.
-[ Debug ] webaudio/AudioBufferSource/audiobuffersource-playbackrate.html [ Crash ]
 
 webkit.org/b/176929 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html [ Pass Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-23  Chris Dumez  <cdumez@apple.com>
+
+        webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=216827
+
+        Reviewed by Darin Adler.
+
+        AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping() would hit an assertion inside
+        finish() because finish() was already called earlier when calling updateSchedulingInfo().
+        updateSchedulingInfo() already takes care of calling finish() when we're done playing.
+        Address the issue by only calling finish() if hasFinished() returns false.
+
+        No new tests, unskipped existing test.
+
+        * Modules/webaudio/AudioBufferSourceNode.cpp:
+        (WebCore::AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping):
+
 2020-09-23  Andres Gonzalez  <andresg_22@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp

@@ -177 +177 @@
         }
 
-        finish();
+        if (!hasFinished())
+            finish();
         return true;
     }