Changeset 267492 in webkit

Timestamp:

Sep 23, 2020, 12:07:10 PM (6 years ago)

Author:

aakash_jain@apple.com

Message:

Notify igalia team about pre-existing test failures and build failures for JSC queues
​https://bugs.webkit.org/show_bug.cgi?id=216889

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Send email for pre-existing jsc build failures.
(AnalyzeJSCTestsResults.send_email_for_pre_existing_failure): Send email for pre-existing jsc test failure.

• BuildSlaveSupport/ews-build/send_email.py:
• BuildSlaveSupport/ews-build/emails.json: Added email address of igalia jsc team.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/emails.json (modified) (1 diff)
• BuildSlaveSupport/ews-build/send_email.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps.py (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/emails.json

@@ -7 +7 @@
       "webkit-ews-bot-watchers@group.apple.com"
   ],
+  "IGALIA_JSC_TEAM_EMAILS": [
+      "jsc32@igalia.com"
+  ],
   "EMAIL_IDS_TO_UNSUBSCRIBE": ["pnormand@igalia.com"]
 }

trunk/Tools/BuildSlaveSupport/ews-build/send_email.py

@@ -81 +81 @@
 def send_email_to_bot_watchers(subject, text, reference=''):
     send_email(get_email_ids('BOT_WATCHERS_EMAILS'), subject, text, reference)
+
+
+def send_email_to_igalia_jsc_team(subject, text, reference=''):
+    send_email(get_email_ids('IGALIA_JSC_TEAM_EMAILS'), subject, text, reference)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -31 +31 @@
 
 from layout_test_failures import LayoutTestFailures
-from send_email import send_email_to_patch_author, send_email_to_bot_watchers
+from send_email import send_email_to_patch_author, send_email_to_bot_watchers, send_email_to_igalia_jsc_team
 
 import json
@@ -43 +43 @@
 EWS_BUILD_URL = 'https://ews-build.webkit.org/'
 EWS_URL = 'https://ews.webkit.org/'
+IGALIA_JSC_QUEUES_PATTERNS = ['armv7', 'mips', 'i386']
 RESULTS_DB_URL = 'https://results.webkit.org/'
 WithProperties = properties.WithProperties
@@ -1549 +1550 @@
                 email_text += u'\n\nError lines:\n\n<code>{}</code>'.format(logs)
             send_email_to_bot_watchers(email_subject, email_text, 'preexisting-build-failure-{}-{}'.format(builder_name, date.today().strftime("%Y-%d-%m")))
+            if any(pattern in builder_name.lower() for pattern in IGALIA_JSC_QUEUES_PATTERNS):
+                send_email_to_igalia_jsc_team(email_subject, email_text, 'preexisting-build-failure-{}-{}'.format(builder_name, date.today().strftime("%Y-%d-%m")))
         except Exception as e:
             print('Error in sending email for build failure: {}'.format(e))
@@ -1812 +1815 @@
             email_text = 'Test {} failed on clean tree run in {}.\n\nBuilder: {}\n\nWorker: {}\n\nHistory: {}'.format(test_name, build_url, builder_name, worker_name, history_url)
             send_email_to_bot_watchers(email_subject, email_text, 'preexisting-{}'.format(test_name))
+            if any(pattern in builder_name.lower() for pattern in IGALIA_JSC_QUEUES_PATTERNS):
+                send_email_to_igalia_jsc_team(email_subject, email_text, 'preexisting-{}'.format(test_name))
         except Exception as e:
             print('Error in sending email for pre-existing failure: {}'.format(e))

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-23  Aakash Jain  <aakash_jain@apple.com>
+
+        Notify igalia team about pre-existing test failures and build failures for JSC queues
+        https://bugs.webkit.org/show_bug.cgi?id=216889
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Send email for pre-existing jsc build failures.
+        (AnalyzeJSCTestsResults.send_email_for_pre_existing_failure): Send email for pre-existing jsc test failure.
+        * BuildSlaveSupport/ews-build/send_email.py:
+        * BuildSlaveSupport/ews-build/emails.json: Added email address of igalia jsc team.
+
 2020-09-23  Truitt Savell  <tsavell@apple.com>