Changeset 267495 in webkit

Timestamp:

Sep 23, 2020, 12:35:19 PM (6 years ago)

Author:

Tadeu Zagallo

Message:

Missing scope release in JSDOMBuiltinConstructorBase
​https://bugs.webkit.org/show_bug.cgi?id=216851
<rdar://problem/69144642>

Reviewed by Yusuke Suzuki.

Source/WebCore:

In JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments, we should release the
ThrowScope before calling into JavaScript since we don't intend to handle the exception.

Test: js/transform-stream.html

• bindings/js/JSDOMBuiltinConstructorBase.cpp:

(WebCore::JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments):

LayoutTests:

• js/script-tests/transform-stream.js: Added.
• js/transform-stream-expected.txt: Added.
• js/transform-stream.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/script-tests/transform-stream.js (added)
• LayoutTests/js/transform-stream-expected.txt (added)
• LayoutTests/js/transform-stream.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-23  Tadeu Zagallo  <tzagallo@apple.com>
+
+        Missing scope release in JSDOMBuiltinConstructorBase
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        <rdar://problem/69144642>
+
+        Reviewed by Yusuke Suzuki.
+
+        * js/script-tests/transform-stream.js: Added.
+        * js/transform-stream-expected.txt: Added.
+        * js/transform-stream.html: Added.
+
 2020-09-23  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-23  Tadeu Zagallo  <tzagallo@apple.com>
+
+        Missing scope release in JSDOMBuiltinConstructorBase
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        <rdar://problem/69144642>
+
+        Reviewed by Yusuke Suzuki.
+
+        In JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments, we should release the
+        ThrowScope before calling into JavaScript since we don't intend to handle the exception.
+
+        Test: js/transform-stream.html
+
+        * bindings/js/JSDOMBuiltinConstructorBase.cpp:
+        (WebCore::JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments):
+
 2020-09-23  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp

@@ -43 +43 @@
         return;
     }
+    scope.release();
     JSC::call(&lexicalGlobalObject, &function, callData, &thisObject, arguments);
 }