Changeset 267524 in webkit

Timestamp:

Sep 24, 2020, 2:17:14 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r267502): [GTK][WPE] ephemeral WebKitWebsiteDataManager ignores TLS errors by default
​https://bugs.webkit.org/show_bug.cgi?id=216919

Reviewed by Adrian Perez de Castro.

Source/WebKit:

Initialize ignoreTLSErrors on website data store for ephemeral sessions.

• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkitWebsiteDataManagerConstructed):

Tools:

Add a test case to check we propagate the setting to the network process for ephemeral sessions too.

• TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:

(EphemeralSSLTest::setup):
(EphemeralSSLTest::teardown):
(testTLSErrorsEphemeral):
(beforeAll):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r267502): [GTK][WPE] ephemeral WebKitWebsiteDataManager ignores TLS errors by default
+        https://bugs.webkit.org/show_bug.cgi?id=216919
+
+        Reviewed by Adrian Perez de Castro.
+
+        Initialize ignoreTLSErrors on website data store for ephemeral sessions.
+
+        * UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
+        (webkitWebsiteDataManagerConstructed):
+
 2020-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp

@@ -245 +245 @@
 
     priv->tlsErrorsPolicy = WEBKIT_TLS_ERRORS_POLICY_FAIL;
+    if (priv->websiteDataStore)
+        priv->websiteDataStore->setIgnoreTLSErrors(false);
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r267502): [GTK][WPE] ephemeral WebKitWebsiteDataManager ignores TLS errors by default
+        https://bugs.webkit.org/show_bug.cgi?id=216919
+
+        Reviewed by Adrian Perez de Castro.
+
+        Add a test case to check we propagate the setting to the network process for ephemeral sessions too.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
+        (EphemeralSSLTest::setup):
+        (EphemeralSSLTest::teardown):
+        (testTLSErrorsEphemeral):
+        (beforeAll):
+
 2020-09-23  Antti Koivisto  <antti@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp

@@ -454 +454 @@
 }
 
+class EphemeralSSLTest : public SSLTest {
+public:
+    MAKE_GLIB_TEST_FIXTURE_WITH_SETUP_TEARDOWN(EphemeralSSLTest, setup, teardown);
+
+    static void setup()
+    {
+        WebViewTest::shouldCreateEphemeralWebView = true;
+    }
+
+    static void teardown()
+    {
+        WebViewTest::shouldCreateEphemeralWebView = false;
+    }
+};
+
+static void testTLSErrorsEphemeral(EphemeralSSLTest* test, gconstpointer)
+{
+    auto* websiteDataManager = webkit_web_view_get_website_data_manager(test->m_webView);
+    g_assert_true(webkit_website_data_manager_is_ephemeral(websiteDataManager));
+    g_assert_cmpint(webkit_website_data_manager_get_tls_errors_policy(websiteDataManager), ==, WEBKIT_TLS_ERRORS_POLICY_FAIL);
+
+    test->loadURI(kHttpsServer->getURIForPath("/").data());
+    test->waitUntilLoadFinished();
+    g_assert_true(test->m_loadFailed);
+    g_assert_true(test->m_loadEvents.contains(LoadTrackingTest::ProvisionalLoadFailed));
+    g_assert_false(test->m_loadEvents.contains(LoadTrackingTest::LoadCommitted));
+}
+
 static void httpsServerCallback(SoupServer* server, SoupMessage* message, const char* path, GHashTable*, SoupClientContext*, gpointer)
 {
@@ -541 +569 @@
     TLSErrorsTest::add("WebKitWebView", "load-failed-with-tls-errors", testLoadFailedWithTLSErrors);
     WebSocketTest::add("WebKitWebView", "web-socket-tls-errors", testWebSocketTLSErrors);
+    EphemeralSSLTest::add("WebKitWebView", "ephemeral-tls-errors", testTLSErrorsEphemeral);
 }