Changeset 267525 in webkit

Timestamp:

Sep 24, 2020, 4:49:36 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, reverting r267507.
​https://bugs.webkit.org/show_bug.cgi?id=216923

Broke two layout tests on windows

Reverted changeset:

"web audio api outputs silence for 302 redirected resource in
safari"
​https://bugs.webkit.org/show_bug.cgi?id=214932
​https://trac.webkit.org/changeset/267507

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect-expected.txt (deleted)
• LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html (deleted)
• LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html (modified) (1 diff)
• LayoutTests/http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect-expected.txt (deleted)
• LayoutTests/http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-24  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r267507.
+        https://bugs.webkit.org/show_bug.cgi?id=216923
+
+        Broke two layout tests on windows
+
+        Reverted changeset:
+
+        "web audio api outputs silence for 302 redirected resource in
+        safari"
+        https://bugs.webkit.org/show_bug.cgi?id=214932
+        https://trac.webkit.org/changeset/267507
+
 2020-09-23  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html

@@ -31 +31 @@
         window.outputArray = new Float32Array(analyser.frequencyBinCount);
         window.silentArray = new Float32Array(analyser.frequencyBinCount);
-        silentArray.fill(-Infinity);
+        silentArray.fill(analyser.minDecibels);
 
         var intervalToken = setInterval(() => {

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-24  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r267507.
+        https://bugs.webkit.org/show_bug.cgi?id=216923
+
+        Broke two layout tests on windows
+
+        Reverted changeset:
+
+        "web audio api outputs silence for 302 redirected resource in
+        safari"
+        https://bugs.webkit.org/show_bug.cgi?id=214932
+        https://trac.webkit.org/changeset/267507
+
 2020-09-24  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp

@@ -124 +124 @@
 bool MediaElementAudioSourceNode::wouldTaintOrigin()
 {
-    // If the resource is redirected to another origin, treat it as tainted if the crossorigin attribute
-    // is not set. This is done for consistency with Blink.
-    if (!m_mediaElement->hasSingleSecurityOrigin() && m_mediaElement->crossOrigin().isNull())
+    if (!m_mediaElement->hasSingleSecurityOrigin())
         return true;