Changeset 267526 in webkit

Timestamp:

Sep 24, 2020, 4:54:00 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, reverting r267495 and r267512.
​https://bugs.webkit.org/show_bug.cgi?id=216924

Broke transform-stream.html test

Reverted changesets:

"Missing scope release in JSDOMBuiltinConstructorBase"
​https://bugs.webkit.org/show_bug.cgi?id=216851
​https://trac.webkit.org/changeset/267495

"Unreviewed, we should put it under js/dom since it is not
usable in JSC shell"
​https://bugs.webkit.org/show_bug.cgi?id=216851
​https://trac.webkit.org/changeset/267512

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/dom/script-tests/transform-stream.js (deleted)
• LayoutTests/js/dom/transform-stream-expected.txt (deleted)
• LayoutTests/js/dom/transform-stream.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-24  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r267495 and r267512.
+        https://bugs.webkit.org/show_bug.cgi?id=216924
+
+        Broke transform-stream.html test
+
+        Reverted changesets:
+
+        "Missing scope release in JSDOMBuiltinConstructorBase"
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        https://trac.webkit.org/changeset/267495
+
+        "Unreviewed, we should put it under js/dom since it is not
+        usable in JSC shell"
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        https://trac.webkit.org/changeset/267512
+
 2020-09-24  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-24  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r267495 and r267512.
+        https://bugs.webkit.org/show_bug.cgi?id=216924
+
+        Broke transform-stream.html test
+
+        Reverted changesets:
+
+        "Missing scope release in JSDOMBuiltinConstructorBase"
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        https://trac.webkit.org/changeset/267495
+
+        "Unreviewed, we should put it under js/dom since it is not
+        usable in JSC shell"
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        https://trac.webkit.org/changeset/267512
+
 2020-09-24  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp

@@ -43 +43 @@
         return;
     }
-    scope.release();
     JSC::call(&lexicalGlobalObject, &function, callData, &thisObject, arguments);
 }