Changeset 267527 in webkit

Timestamp:

Sep 24, 2020, 5:52:35 AM (6 years ago)

Author:

cathiechen

Message:

Root node with stateless wheel event isn't always scrollable
​https://bugs.webkit.org/show_bug.cgi?id=216875

Reviewed by Simon Fraser.

Root nodes are not always capable of handling wheel event. When it is a stateless wheel event which
does not trigger rubber-band, we should check the scroll content of the root node.

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::canHandleWheelEvent const): Stateless wheel event
doesn't trigger rubber-band, should check the scroll content.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ScrollingTreeScrollingNode.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-24  Cathie Chen  <cathiechen@igalia.com>
+
+        Root node with stateless wheel event isn't always scrollable
+        https://bugs.webkit.org/show_bug.cgi?id=216875
+
+        Reviewed by Simon Fraser.
+
+        Root nodes are not always capable of handling wheel event. When it is a stateless wheel event which
+        does not trigger rubber-band, we should check the scroll content of the root node.
+
+        * page/scrolling/ScrollingTreeScrollingNode.cpp:
+        (WebCore::ScrollingTreeScrollingNode::canHandleWheelEvent const): Stateless wheel event
+        doesn't trigger rubber-band, should check the scroll content.
+
 2020-09-24  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp

@@ -145 +145 @@
 
     // We always rubber-band the latched node, or the root node.
-    if (isLatchedNode() || isRootNode())
+    // The stateless wheel event doesn't trigger rubber-band.
+    if (isLatchedNode() || (isRootNode() && !wheelEvent.isNonGestureEvent()))
         return true;
-    
+
     return eventCanScrollContents(wheelEvent);
 }