Changeset 267537 in webkit

Timestamp:

Sep 24, 2020, 10:47:53 AM (6 years ago)

Author:

Chris Dumez

Message:

Drop AudioNode::reset() and all its overrides
​https://bugs.webkit.org/show_bug.cgi?id=216932

Reviewed by Eric Carlson.

Drop AudioNode::reset() and all its overrides. This is dead code.

• Modules/webaudio/AnalyserNode.cpp:
• Modules/webaudio/AnalyserNode.h:
• Modules/webaudio/AudioBasicProcessorNode.cpp:
• Modules/webaudio/AudioBasicProcessorNode.h:
• Modules/webaudio/AudioBufferSourceNode.cpp:
• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/AudioDestinationNode.h:
• Modules/webaudio/AudioNode.h:
• Modules/webaudio/ChannelMergerNode.cpp:
• Modules/webaudio/ChannelMergerNode.h:
• Modules/webaudio/ChannelSplitterNode.cpp:
• Modules/webaudio/ChannelSplitterNode.h:
• Modules/webaudio/ConstantSourceNode.h:
• Modules/webaudio/ConvolverNode.cpp:
• Modules/webaudio/ConvolverNode.h:
• Modules/webaudio/DynamicsCompressorNode.cpp:
• Modules/webaudio/DynamicsCompressorNode.h:
• Modules/webaudio/GainNode.cpp:
• Modules/webaudio/GainNode.h:
• Modules/webaudio/MediaElementAudioSourceNode.cpp:
• Modules/webaudio/MediaElementAudioSourceNode.h:
• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
• Modules/webaudio/MediaStreamAudioDestinationNode.h:
• Modules/webaudio/MediaStreamAudioSourceNode.h:
• Modules/webaudio/OscillatorNode.cpp:
• Modules/webaudio/OscillatorNode.h:
• Modules/webaudio/PannerNode.cpp:
• Modules/webaudio/PannerNode.h:
• Modules/webaudio/RealtimeAnalyser.cpp:
• Modules/webaudio/RealtimeAnalyser.h:
• Modules/webaudio/ScriptProcessorNode.cpp:
• Modules/webaudio/ScriptProcessorNode.h:
• Modules/webaudio/StereoPannerNode.h:
• Modules/webaudio/WebKitAudioPannerNode.cpp:
• Modules/webaudio/WebKitAudioPannerNode.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/AnalyserNode.cpp (modified) (1 diff)
• Modules/webaudio/AnalyserNode.h (modified) (1 diff)
• Modules/webaudio/AudioBasicProcessorNode.cpp (modified) (1 diff)
• Modules/webaudio/AudioBasicProcessorNode.h (modified) (1 diff)
• Modules/webaudio/AudioBufferSourceNode.cpp (modified) (1 diff)
• Modules/webaudio/AudioBufferSourceNode.h (modified) (1 diff)
• Modules/webaudio/AudioDestinationNode.h (modified) (1 diff)
• Modules/webaudio/AudioNode.h (modified) (1 diff)
• Modules/webaudio/ChannelMergerNode.cpp (modified) (1 diff)
• Modules/webaudio/ChannelMergerNode.h (modified) (1 diff)
• Modules/webaudio/ChannelSplitterNode.cpp (modified) (1 diff)
• Modules/webaudio/ChannelSplitterNode.h (modified) (1 diff)
• Modules/webaudio/ConstantSourceNode.h (modified) (1 diff)
• Modules/webaudio/ConvolverNode.cpp (modified) (1 diff)
• Modules/webaudio/ConvolverNode.h (modified) (1 diff)
• Modules/webaudio/DynamicsCompressorNode.cpp (modified) (1 diff)
• Modules/webaudio/DynamicsCompressorNode.h (modified) (1 diff)
• Modules/webaudio/GainNode.cpp (modified) (1 diff)
• Modules/webaudio/GainNode.h (modified) (1 diff)
• Modules/webaudio/MediaElementAudioSourceNode.cpp (modified) (1 diff)
• Modules/webaudio/MediaElementAudioSourceNode.h (modified) (1 diff)
• Modules/webaudio/MediaStreamAudioDestinationNode.cpp (modified) (1 diff)
• Modules/webaudio/MediaStreamAudioDestinationNode.h (modified) (1 diff)
• Modules/webaudio/MediaStreamAudioSourceNode.h (modified) (1 diff)
• Modules/webaudio/OscillatorNode.cpp (modified) (1 diff)
• Modules/webaudio/OscillatorNode.h (modified) (1 diff)
• Modules/webaudio/PannerNode.cpp (modified) (1 diff)
• Modules/webaudio/PannerNode.h (modified) (1 diff)
• Modules/webaudio/RealtimeAnalyser.cpp (modified) (1 diff)
• Modules/webaudio/RealtimeAnalyser.h (modified) (1 diff)
• Modules/webaudio/ScriptProcessorNode.cpp (modified) (1 diff)
• Modules/webaudio/ScriptProcessorNode.h (modified) (1 diff)
• Modules/webaudio/StereoPannerNode.h (modified) (1 diff)
• Modules/webaudio/WebKitAudioPannerNode.cpp (modified) (1 diff)
• Modules/webaudio/WebKitAudioPannerNode.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-24  Chris Dumez  <cdumez@apple.com>
+
+        Drop AudioNode::reset() and all its overrides
+        https://bugs.webkit.org/show_bug.cgi?id=216932
+
+        Reviewed by Eric Carlson.
+
+        Drop AudioNode::reset() and all its overrides. This is dead code.
+
+        * Modules/webaudio/AnalyserNode.cpp:
+        * Modules/webaudio/AnalyserNode.h:
+        * Modules/webaudio/AudioBasicProcessorNode.cpp:
+        * Modules/webaudio/AudioBasicProcessorNode.h:
+        * Modules/webaudio/AudioBufferSourceNode.cpp:
+        * Modules/webaudio/AudioBufferSourceNode.h:
+        * Modules/webaudio/AudioDestinationNode.h:
+        * Modules/webaudio/AudioNode.h:
+        * Modules/webaudio/ChannelMergerNode.cpp:
+        * Modules/webaudio/ChannelMergerNode.h:
+        * Modules/webaudio/ChannelSplitterNode.cpp:
+        * Modules/webaudio/ChannelSplitterNode.h:
+        * Modules/webaudio/ConstantSourceNode.h:
+        * Modules/webaudio/ConvolverNode.cpp:
+        * Modules/webaudio/ConvolverNode.h:
+        * Modules/webaudio/DynamicsCompressorNode.cpp:
+        * Modules/webaudio/DynamicsCompressorNode.h:
+        * Modules/webaudio/GainNode.cpp:
+        * Modules/webaudio/GainNode.h:
+        * Modules/webaudio/MediaElementAudioSourceNode.cpp:
+        * Modules/webaudio/MediaElementAudioSourceNode.h:
+        * Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
+        * Modules/webaudio/MediaStreamAudioDestinationNode.h:
+        * Modules/webaudio/MediaStreamAudioSourceNode.h:
+        * Modules/webaudio/OscillatorNode.cpp:
+        * Modules/webaudio/OscillatorNode.h:
+        * Modules/webaudio/PannerNode.cpp:
+        * Modules/webaudio/PannerNode.h:
+        * Modules/webaudio/RealtimeAnalyser.cpp:
+        * Modules/webaudio/RealtimeAnalyser.h:
+        * Modules/webaudio/ScriptProcessorNode.cpp:
+        * Modules/webaudio/ScriptProcessorNode.h:
+        * Modules/webaudio/StereoPannerNode.h:
+        * Modules/webaudio/WebKitAudioPannerNode.cpp:
+        * Modules/webaudio/WebKitAudioPannerNode.h:
+
 2020-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp

@@ -105 +105 @@
 }
 
-void AnalyserNode::reset()
-{
-    m_analyser.reset();
-}
-
 ExceptionOr<void> AnalyserNode::setFftSize(unsigned size)
 {

trunk/Source/WebCore/Modules/webaudio/AnalyserNode.h

@@ -63 +63 @@
 
     void process(size_t framesToProcess) final;
-    void reset() final;
     void updatePullStatus() final;
 

trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.cpp

@@ -103 +103 @@
 }
 
-void AudioBasicProcessorNode::reset()
-{
-    if (processor())
-        processor()->reset();
-}
-
 // As soon as we know the channel count of our input, we can lazily initialize.
 // Sometimes this may be called more than once with different channel counts, in which case we must safely

trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h

@@ -44 +44 @@
     void processOnlyAudioParams(size_t framesToProcess) override;
     void pullInputs(size_t framesToProcess) override;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;

trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp

@@ -426 +426 @@
 }
 
-
-void AudioBufferSourceNode::reset()
-{
-    m_virtualReadIndex = 0;
-}
-
 ExceptionOr<void> AudioBufferSourceNode::setBuffer(RefPtr<AudioBuffer>&& buffer)
 {

trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h

@@ -50 +50 @@
     // AudioNode
     void process(size_t framesToProcess) final;
-    void reset() final;
 
     // setBuffer() is called on the main thread.  This is the buffer we use for playback.

trunk/Source/WebCore/Modules/webaudio/AudioDestinationNode.h

@@ -41 +41 @@
     // AudioNode   
     void process(size_t) override { }; // we're pulled by hardware so this is never called
-    void reset() override { m_currentSampleFrame = 0; }
     
     // The audio hardware calls render() to get the next render quantum of audio into destinationBus.

trunk/Source/WebCore/Modules/webaudio/AudioNode.h

@@ -122 +122 @@
     virtual void processOnlyAudioParams(size_t) { }
 
-    // Resets DSP processing state (clears delay lines, filter memory, etc.)
-    // Called from context's audio thread.
-    virtual void reset() = 0;
-
     // No significant resources should be allocated until initialize() is called.
     // Processing may not occur until a node is initialized.

trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.cpp

@@ -107 +107 @@
 }
 
-void ChannelMergerNode::reset()
-{
-}
-
 ExceptionOr<void> ChannelMergerNode::setChannelCount(unsigned channelCount)
 {

trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.h

@@ -43 +43 @@
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override;
     
     ExceptionOr<void> setChannelCount(unsigned) final;

trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp

@@ -94 +94 @@
 }
 
-void ChannelSplitterNode::reset()
-{
-}
-
 ExceptionOr<void> ChannelSplitterNode::setChannelCount(unsigned channelCount)
 {

trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.h

@@ -39 +39 @@
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override;
     
     ExceptionOr<void> setChannelCount(unsigned) final;

trunk/Source/WebCore/Modules/webaudio/ConstantSourceNode.h

@@ -44 +44 @@
 private:
     void process(size_t framesToProcess) final;
-    void reset() final { };
 
     ConstantSourceNode(BaseAudioContext&, float);

trunk/Source/WebCore/Modules/webaudio/ConvolverNode.cpp

@@ -117 +117 @@
 }
 
-void ConvolverNode::reset()
-{
-    auto locker = holdLock(m_processMutex);
-    if (m_reverb)
-        m_reverb->reset();
-}
-
 ExceptionOr<void> ConvolverNode::setBuffer(RefPtr<AudioBuffer>&& buffer)
 {

trunk/Source/WebCore/Modules/webaudio/ConvolverNode.h

@@ -59 +59 @@
 
     void process(size_t framesToProcess) final;
-    void reset() final;
     void checkNumberOfChannelsForInput(AudioNodeInput*) final;
 

trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.cpp

@@ -116 +116 @@
 }
 
-void DynamicsCompressorNode::reset()
-{
-    m_dynamicsCompressor->reset();
-}
-
 void DynamicsCompressorNode::initialize()
 {

trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.h

@@ -45 +45 @@
     void process(size_t framesToProcess) override;
     void processOnlyAudioParams(size_t framesToProcess) final;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;

trunk/Source/WebCore/Modules/webaudio/GainNode.cpp

@@ -111 +111 @@
 }
 
-void GainNode::reset()
-{
-}
-
 // FIXME: this can go away when we do mixing with gain directly in summing junction of AudioNodeInput
 //

trunk/Source/WebCore/Modules/webaudio/GainNode.h

@@ -45 +45 @@
     void process(size_t framesToProcess) override;
     void processOnlyAudioParams(size_t framesToProcess) final;
-    void reset() override;
 
     // Called in the main thread when the number of channels for the input may have changed.

trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp

@@ -177 +177 @@
 }
 
-void MediaElementAudioSourceNode::reset()
-{
-}
-
 } // namespace WebCore
 

trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h

@@ -51 +51 @@
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override;
     
     // AudioSourceProviderClient

trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.cpp

@@ -75 +75 @@
 }
 
-void MediaStreamAudioDestinationNode::reset()
-{
-}
-
 } // namespace WebCore
 

trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h

@@ -48 +48 @@
     // AudioNode.
     void process(size_t framesToProcess) final;
-    void reset() final;
     
 private:

trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h

@@ -50 +50 @@
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override { }
 
     // AudioSourceProviderClient

trunk/Source/WebCore/Modules/webaudio/OscillatorNode.cpp

@@ -437 +437 @@
 }
 
-void OscillatorNode::reset()
-{
-    m_virtualReadIndex = 0;
-}
-
 void OscillatorNode::setPeriodicWave(PeriodicWave& periodicWave)
 {

trunk/Source/WebCore/Modules/webaudio/OscillatorNode.h

@@ -58 +58 @@
 private:
     void process(size_t framesToProcess) final;
-    void reset() final;
 
     double tailTime() const final { return 0; }

trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp

@@ -272 +272 @@
 }
 
-void PannerNode::reset()
-{
-    if (m_panner.get())
-        m_panner->reset();
-}
-
 void PannerNode::initialize()
 {

trunk/Source/WebCore/Modules/webaudio/PannerNode.h

@@ -73 +73 @@
     void processOnlyAudioParams(size_t framesToProcess) final;
     void pullInputs(size_t framesToProcess) override;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;

trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp

@@ -68 +68 @@
 RealtimeAnalyser::~RealtimeAnalyser() = default;
 
-void RealtimeAnalyser::reset()
-{
-    m_writeIndex = 0;
-    m_inputBuffer.zero();
-    m_magnitudeBuffer.zero();
-}
-
 bool RealtimeAnalyser::setFftSize(size_t size)
 {

trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h

@@ -43 +43 @@
     RealtimeAnalyser();
     virtual ~RealtimeAnalyser();
-    
-    void reset();
 
     size_t fftSize() const { return m_fftSize; }

trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp

@@ -240 +240 @@
 }
 
-void ScriptProcessorNode::reset()
-{
-    m_bufferReadWriteIndex = 0;
-    m_doubleBufferIndex = 0;
-
-    for (unsigned i = 0; i < 2; ++i) {
-        m_inputBuffers[i]->zero();
-        m_outputBuffers[i]->zero();
-    }
-}
-
 ExceptionOr<void> ScriptProcessorNode::setChannelCount(unsigned channelCount)
 {

trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h

@@ -61 +61 @@
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;

trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.h

@@ -53 +53 @@
     void process(size_t framesToProcess) final;
     void processOnlyAudioParams(size_t framesToProcess) final;
-    void reset() final { };
     bool requiresTailProcessing() const final { return false; }
 

trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.cpp

@@ -136 +136 @@
 }
 
-void WebKitAudioPannerNode::reset()
-{
-    if (m_panner.get())
-        m_panner->reset();
-}
-
 void WebKitAudioPannerNode::initialize()
 {

trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.h

@@ -67 +67 @@
     void process(size_t framesToProcess) override;
     void pullInputs(size_t framesToProcess) override;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;