Changeset 267538 in webkit

Timestamp:

Sep 24, 2020, 11:23:57 AM (6 years ago)

Author:

basuke.suzuki@sony.com

Message:

[PlayStation] Stop raising SIGPIPE when client side of RemoteInspector dies
​https://bugs.webkit.org/show_bug.cgi?id=216805

Reviewed by Don Olmstead.

When communication is stopped caused by peer crash or non-polite close, SIGPIPE will be
raised on BSD (and maybe on Linux). We prefer to handle those events by returning error.

On Windows, there's no such fancy feature from the beginning.

• inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:

(Inspector::Socket::read):
(Inspector::Socket::write):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-09-24  Basuke Suzuki  <basuke.suzuki@sony.com>
+
+        [PlayStation] Stop raising SIGPIPE when client side of RemoteInspector dies
+        https://bugs.webkit.org/show_bug.cgi?id=216805
+
+        Reviewed by Don Olmstead.
+
+        When communication is stopped caused by peer crash or non-polite close, SIGPIPE will be
+        raised on BSD (and maybe on Linux). We prefer to handle those events by returning error.
+
+        On Windows, there's no such fancy feature from the beginning.
+
+        * inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
+        (Inspector::Socket::read):
+        (Inspector::Socket::write):
+
 2020-09-24  Angelos Oikonomopoulos  <angelos@igalia.com>
 

trunk/Source/JavaScriptCore/inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp

@@ -207 +207 @@
     ASSERT(isValid(socket));
 
-    ssize_t readSize = ::read(socket, buffer, bufferSize);
+    ssize_t readSize = ::recv(socket, buffer, bufferSize, MSG_NOSIGNAL);
     if (readSize >= 0)
         return static_cast<size_t>(readSize);
@@ -219 +219 @@
     ASSERT(isValid(socket));
 
-    ssize_t writeSize = ::write(socket, data, size);
+    ssize_t writeSize = ::send(socket, data, size, MSG_NOSIGNAL);
     if (writeSize >= 0)
         return static_cast<size_t>(writeSize);