Changeset 267545 in webkit

Timestamp:

Sep 24, 2020, 2:36:45 PM (6 years ago)

Author:

BJ Burg

Message:

REGRESSION(iOS WebDriver): action chains with 'Touch' pointerType don't work on Mac
​https://bugs.webkit.org/show_bug.cgi?id=216937
<rdar://problem/69149171>

Reviewed by Darin Adler.

Before iOS WebDriver shipped, 'Touch' was unconditionally aliased to 'Mouse.'
Make sure the aliasing happens for macOS so the command doesn't fail frivolously.

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::performInteractionSequence):
Alias 'Touch' to 'Mouse' when touch is not available and mouse is.
This is the case for macOS.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Automation/WebAutomationSession.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-24  Brian Burg  <bburg@apple.com>
+
+        REGRESSION(iOS WebDriver): action chains with 'Touch' pointerType don't work on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=216937
+        <rdar://problem/69149171>
+
+        Reviewed by Darin Adler.
+
+        Before iOS WebDriver shipped, 'Touch' was unconditionally aliased to 'Mouse.'
+        Make sure the aliasing happens for macOS so the command doesn't fail frivolously.
+
+        * UIProcess/Automation/WebAutomationSession.cpp:
+        (WebKit::WebAutomationSession::performInteractionSequence):
+        Alias 'Touch' to 'Mouse' when touch is not available and mouse is.
+        This is the case for macOS. 
+
 2020-09-24  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp

@@ -1856 +1856 @@
         if (inputSourceType == SimulatedInputSourceType::Mouse)
             inputSourceType = SimulatedInputSourceType::Touch;
+#elif ENABLE(WEBDRIVER_MOUSE_INTERACTIONS) && !ENABLE(WEBDRIVER_TOUCH_INTERACTIONS)
+        if (inputSourceType == SimulatedInputSourceType::Touch)
+            inputSourceType = SimulatedInputSourceType::Mouse;
 #endif
 #if !ENABLE(WEBDRIVER_MOUSE_INTERACTIONS)