Changeset 267546 in webkit

Timestamp:

Sep 24, 2020, 2:47:43 PM (6 years ago)

Author:

Nikita Vasilyev

Message:

REGRESSION(r267379): Web Inspector: Sources navigation sidebar is empty every other time it's selected
​https://bugs.webkit.org/show_bug.cgi?id=216942
<rdar://problem/69520398>

Reviewed by Brian Burg.

• UserInterface/Views/Sidebar.js:

(WI.Sidebar.prototype.insertSidebarPanel):
insertSidebarPanel was exiting early when sidebarPanel.parentSidebar matched the current sidebar,
creating a state when this._sidebarPanels is an empty array.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/Sidebar.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-09-24  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION(r267379): Web Inspector: Sources navigation sidebar is empty every other time it's selected
+        https://bugs.webkit.org/show_bug.cgi?id=216942
+        <rdar://problem/69520398>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/Sidebar.js:
+        (WI.Sidebar.prototype.insertSidebarPanel):
+        insertSidebarPanel was exiting early when sidebarPanel.parentSidebar matched the current sidebar,
+        creating a state when `this._sidebarPanels` is an empty array.
+
 2020-09-22  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js

@@ -73 +73 @@
             return;
 
-        console.assert(!sidebarPanel.parentSidebar);
-        if (sidebarPanel.parentSidebar)
-            return;
+        if (sidebarPanel.parentSidebar && sidebarPanel.parentSidebar !== this) {
+            console.assert(false, "Failed to insert sidebar panel", sidebarPanel);
+            return;
+        }
 
         console.assert(index >= 0 && index <= this._sidebarPanels.length);