Changeset 267577 in webkit

Timestamp:

Sep 25, 2020, 10:42:26 AM (6 years ago)

Author:

Nikita Vasilyev

Message:

Uncaught Exception: TypeError: null is not an object (evaluating 'this.listItemElement.classList')
​https://bugs.webkit.org/show_bug.cgi?id=216307
<rdar://problem/68565824>

Reviewed by Brian Burg.

• UserInterface/Views/DOMTreeUpdater.js:

(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
Don't update the element if it hasn't been attached yet. It will use the latest data when attached.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DOMTreeUpdater.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-09-25  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Uncaught Exception: TypeError: null is not an object (evaluating 'this.listItemElement.classList')
+        https://bugs.webkit.org/show_bug.cgi?id=216307
+        <rdar://problem/68565824>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/DOMTreeUpdater.js:
+        (WI.DOMTreeUpdater.prototype._updateModifiedNodes):
+        Don't update the element if it hasn't been attached yet. It will use the latest data when attached.
+
 2020-09-24  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js

@@ -125 +125 @@
 
         for (let parentTreeElement of parentElementsToUpdate) {
-            if (parentTreeElement.treeOutline) {
+            if (parentTreeElement.treeOutline && parentTreeElement.listItemElement) {
                 parentTreeElement.updateTitle();
                 parentTreeElement.updateChildren();