Changeset 267590 in webkit

Timestamp:

Sep 25, 2020, 1:19:39 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Simplify SVGTests.hasExtension idl
​https://bugs.webkit.org/show_bug.cgi?id=216984

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-25
Reviewed by Sam Weinig.

Simplify SVGTests.hasExtension idl by removing optional and default parameter.
Skipping the parameter will now result in the parameter being a null string,
which gives the same behaviour as before as the method just checks
against non null namespaces.

[1] ​https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension

• page/DOMWindow.idl:
• svg/SVGTests.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.idl (modified) (1 diff)
• svg/SVGTests.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-25  Rob Buis  <rbuis@igalia.com>
+
+        Simplify SVGTests.hasExtension idl
+        https://bugs.webkit.org/show_bug.cgi?id=216984
+
+        Reviewed by Sam Weinig.
+
+        Simplify SVGTests.hasExtension idl by removing optional and default parameter.
+        Skipping the parameter will now result in the parameter being a null string,
+        which gives the same behaviour as before as the method just checks
+        against non null namespaces.
+
+        [1] https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension
+
+        * page/DOMWindow.idl:
+        * svg/SVGTests.idl:
+
 2020-09-25  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/page/DOMWindow.idl

@@ -157 +157 @@
     attribute DOMString defaultStatus;
     [ImplementedAs=defaultStatus] attribute DOMString defaultstatus; // For compatibility with legacy content.
-    boolean find(optional DOMString string, optional boolean caseSensitive = false, optional boolean backwards = false, optional boolean wrap = false, optional boolean wholeWord = false, optional boolean searchInFrames = false, optional boolean showDialog = false); // FIXME: Using "undefined" as default parameter value is wrong.
+    boolean find(optional DOMString string, optional boolean caseSensitive = false, optional boolean backwards = false, optional boolean wrap = false, optional boolean wholeWord = false, optional boolean searchInFrames = false, optional boolean showDialog = false);
     [Replaceable] readonly attribute  boolean offscreenBuffering;
     [Replaceable] readonly attribute long screenLeft;

trunk/Source/WebCore/svg/SVGTests.idl

@@ -34 +34 @@
 
     [SameObject] readonly attribute SVGStringList requiredFeatures;
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    boolean hasExtension(optional DOMString extension = "undefined");
+    boolean hasExtension(DOMString extension);
 };