⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 267592 in webkit


Ignore:
Timestamp:
Sep 25, 2020, 2:26:29 PM (6 years ago)
Author:
graouts@webkit.org
Message:

Add an experimental feature flag for CSS individual transform properties
​https://bugs.webkit.org/show_bug.cgi?id=216271
<rdar://problem/68914539>

Reviewed by Dean Jackson.

Source/WebCore:

  • page/Settings.yaml:

Source/WebKit:

  • Shared/WebPreferencesExperimental.yaml:

Source/WebKitLegacy/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]):
(-[WebPreferences cssIndividualTransformPropertiesEnabled]):
(-[WebPreferences CSSIndividualTransformPropertiesEnabled]):

  • WebView/WebPreferencesExperimental.yaml:
  • WebView/WebPreferencesPrivate.h:

Source/WebKitLegacy/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::CSSIndividualTransformPropertiesEnabled):
(WebPreferences::setCSSIndividualTransformPropertiesEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

Location:
trunk
Files:
18 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r267591 r267592  
     12020-09-25  Antoine Quint  <graouts@webkit.org>
     2
     3        Add an experimental feature flag for CSS individual transform properties
     4        https://bugs.webkit.org/show_bug.cgi?id=216271
     5        <rdar://problem/68914539>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * page/Settings.yaml:
     10
    1112020-09-25  Chris Dumez  <cdumez@apple.com>
    212

  • trunk/Source/WebCore/page/Settings.yaml

    r267516 r267592  
    11211121scriptMarkupEnabled:
    11221122  initial: true
     1123
     1124cssIndividualTransformPropertiesEnabled:
     1125  initial: false

  • trunk/Source/WebKit/ChangeLog

    r267569 r267592  
     12020-09-25  Antoine Quint  <graouts@webkit.org>
     2
     3        Add an experimental feature flag for CSS individual transform properties
     4        https://bugs.webkit.org/show_bug.cgi?id=216271
     5        <rdar://problem/68914539>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * Shared/WebPreferencesExperimental.yaml:
     10
    1112020-09-25  Per Arne Vollan  <pvollan@apple.com>
    212

  • trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml

    r267488 r267592  
    545545  humanReadableDescription: "Disable Media Experience PID Inheritance"
    546546  condition: HAVE(CELESTIAL)
     547
     548CSSIndividualTransformPropertiesEnabled:
     549  type: bool
     550  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
     551  humanReadableName: "CSS Individual Transform Properties"
     552  humanReadableDescription: "Support for the translate, scale and rotate CSS properties"

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r267576 r267592  
     12020-09-25  Antoine Quint  <graouts@webkit.org>
     2
     3        Add an experimental feature flag for CSS individual transform properties
     4        https://bugs.webkit.org/show_bug.cgi?id=216271
     5        <rdar://problem/68914539>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * WebView/WebPreferenceKeysPrivate.h:
     10        * WebView/WebPreferences.mm:
     11        (-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]):
     12        (-[WebPreferences cssIndividualTransformPropertiesEnabled]):
     13        (-[WebPreferences CSSIndividualTransformPropertiesEnabled]):
     14        * WebView/WebPreferencesExperimental.yaml:
     15        * WebView/WebPreferencesPrivate.h:
     16
    1172020-09-24  Darin Adler  <darin@apple.com>
    218

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h

    r267575 r267592  
    288288#define WebKitTransformStreamAPIEnabledPreferenceKey @"WebKitTransformStreamAPIEnabled"
    289289#define WebKitMediaRecorderEnabledPreferenceKey @"WebKitMediaRecorderEnabled"
    290 
     290#define WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey @"WebKitCSSIndividualTransformPropertiesEnabled"
    291291
    292292// The preference keys below this point are deprecated and have no effect. They should

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm

    r267575 r267592  
    32073207}
    32083208
     3209- (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag
     3210{
     3211    [self _setBoolValue:flag forKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
     3212}
     3213
     3214- (BOOL)cssIndividualTransformPropertiesEnabled
     3215{
     3216    return [self _boolValueForKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
     3217}
     3218
    32093219@end
    32103220
    … …  
    35813591}
    35823592
     3593- (BOOL)CSSIndividualTransformPropertiesEnabled
     3594{
     3595    return [self _boolValueForKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
     3596}
     3597
     3598- (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag
     3599{
     3600    [self _setBoolValue:flag forKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
     3601}
     3602
    35833603@end
    35843604

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesExperimental.yaml

    r267575 r267592  
    592592  webcoreBinding: RuntimeEnabledFeatures
    593593  condition: HAVE(NSURLSESSION_WEBSOCKET)
     594
     595CSSIndividualTransformPropertiesEnabled:
     596  type: bool
     597  defaultValue: false
     598  humanReadableName: "CSS Individual Transform Properties"
     599  humanReadableDescription: "Support for the translate, scale and rotate CSS properties"

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

    r267575 r267592  
    643643@property (nonatomic) BOOL mediaRecorderEnabled;
    644644@property (nonatomic, setter=_setMediaRecorderEnabled:) BOOL _mediaRecorderEnabled;
     645@property (nonatomic) BOOL CSSIndividualTransformPropertiesEnabled;
    645646@end
    646647

  • trunk/Source/WebKitLegacy/win/ChangeLog

    r267222 r267592  
     12020-09-25  Antoine Quint  <graouts@webkit.org>
     2
     3        Add an experimental feature flag for CSS individual transform properties
     4        https://bugs.webkit.org/show_bug.cgi?id=216271
     5        <rdar://problem/68914539>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * Interfaces/IWebPreferencesPrivate.idl:
     10        * WebPreferenceKeysPrivate.h:
     11        * WebPreferences.cpp:
     12        (WebPreferences::initializeDefaultSettings):
     13        (WebPreferences::CSSIndividualTransformPropertiesEnabled):
     14        (WebPreferences::setCSSIndividualTransformPropertiesEnabled):
     15        * WebPreferences.h:
     16        * WebView.cpp:
     17        (WebView::notifyPreferencesChanged):
     18
    1192020-09-17  Sam Weinig  <weinig@apple.com>
    220

  • trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl

    r267188 r267592  
    257257    HRESULT setWebSQLEnabled([in] BOOL enabled);
    258258    HRESULT webSQLEnabled([out, retval] BOOL* enabled);
     259    HRESULT CSSIndividualTransformPropertiesEnabled([out, retval] BOOL* enabled);
     260    HRESULT setCSSIndividualTransformPropertiesEnabled([in] BOOL enabled);
    259261}
    260262

  • trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h

    r267188 r267592  
    228228
    229229#define WebKitWebSQLEnabledPreferenceKey "WebKitWebSQLEnabled"
     230
     231#define WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey "WebKitCSSIndividualTransformPropertiesEnabled"

  • trunk/Source/WebKitLegacy/win/WebPreferences.cpp

    r267222 r267592  
    344344    CFDictionaryAddValue(defaults, CFSTR(WebKitWebSQLEnabledPreferenceKey), kCFBooleanFalse);
    345345
     346    CFDictionaryAddValue(defaults, CFSTR(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey), kCFBooleanFalse);
     347
    346348    defaultSettings = defaults;
    347349#endif
    … …  
    24672469    return S_OK;
    24682470}
     2471
     2472HRESULT WebPreferences::CSSIndividualTransformPropertiesEnabled(_Out_ BOOL* enabled)
     2473{
     2474    if (!enabled)
     2475        return E_POINTER;
     2476    *enabled = boolValueForKey(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey);
     2477    return S_OK;
     2478}
     2479
     2480HRESULT WebPreferences::setCSSIndividualTransformPropertiesEnabled(BOOL enabled)
     2481{
     2482    setBoolValue(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey, enabled);
     2483    return S_OK;
     2484}

  • trunk/Source/WebKitLegacy/win/WebPreferences.h

    r267188 r267592  
    298298    virtual HRESULT STDMETHODCALLTYPE webSQLEnabled(_Out_ BOOL*);
    299299    virtual HRESULT STDMETHODCALLTYPE setWebSQLEnabled(BOOL);
     300    virtual HRESULT STDMETHODCALLTYPE CSSIndividualTransformPropertiesEnabled(_Out_ BOOL*);
     301    virtual HRESULT STDMETHODCALLTYPE setCSSIndividualTransformPropertiesEnabled(BOOL);
    300302
    301303    // IWebPreferencesPrivate8

  • trunk/Source/WebKitLegacy/win/WebView.cpp

    r267222 r267592  
    53055305    settings.setCSSOMViewSmoothScrollingEnabled(!!enabled);
    53065306
     5307    hr = prefsPrivate->CSSIndividualTransformPropertiesEnabled(&enabled);
     5308    if (FAILED(hr))
     5309        return hr;
     5310    settings.setCSSIndividualTransformPropertiesEnabled(!!enabled);
     5311
    53075312    hr = preferences->privateBrowsingEnabled(&enabled);
    53085313    if (FAILED(hr))

  • trunk/Tools/ChangeLog

    r267586 r267592  
     12020-09-25  Antoine Quint  <graouts@webkit.org>
     2
     3        Add an experimental feature flag for CSS individual transform properties
     4        https://bugs.webkit.org/show_bug.cgi?id=216271
     5        <rdar://problem/68914539>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * DumpRenderTree/mac/DumpRenderTree.mm:
     10        (enableExperimentalFeatures):
     11        * DumpRenderTree/win/DumpRenderTree.cpp:
     12        (enableExperimentalFeatures):
     13
    1142020-09-25  Wenson Hsieh  <wenson_hsieh@apple.com>
    215

  • trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

    r267222 r267592  
    838838    [preferences setAspectRatioOfImgFromWidthAndHeightEnabled:YES];
    839839    [preferences setCSSOMViewSmoothScrollingEnabled:YES];
     840    [preferences setCSSIndividualTransformPropertiesEnabled:YES];
    840841}
    841842

  • trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp

    r267222 r267592  
    805805    // FIXME: WebRTC
    806806    prefsPrivate->setCSSOMViewSmoothScrollingEnabled(TRUE);
     807    prefsPrivate->setCSSIndividualTransformPropertiesEnabled(TRUE);
    807808}
    808809
Note: See TracChangeset for help on using the changeset viewer.