Changeset 267611 in webkit

Timestamp:

Sep 25, 2020, 5:14:42 PM (6 years ago)

Author:

Simon Fraser

Message:

Make renderingUpdateScheduler() internal to Page
​https://bugs.webkit.org/show_bug.cgi?id=216993

Reviewed by Said Abou-Hallawa.

renderingUpdateScheduler() should be an implementation detail of Page.

Also add some explanatory comments.

• dom/Document.cpp:

(WebCore::Document::scheduleTimedRenderingUpdate):

• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::scheduleAnimation):

• page/Page.cpp:

(WebCore::Page::scheduleImmediateRenderingUpdate):

• page/Page.h:
• page/PageOverlayController.cpp:

(WebCore::PageOverlayController::didChangeViewExposedRect):
(WebCore::PageOverlayController::notifyFlushRequired):

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::notifyFlushRequired):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)
• dom/ScriptedAnimationController.cpp (modified) (1 diff)
• page/Page.cpp (modified) (2 diffs)
• page/Page.h (modified) (5 diffs)
• page/PageOverlayController.cpp (modified) (2 diffs)
• page/mac/ServicesOverlayController.mm (modified) (1 diff)
• rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-25  Simon Fraser  <simon.fraser@apple.com>
+
+        Make renderingUpdateScheduler() internal to Page
+        https://bugs.webkit.org/show_bug.cgi?id=216993
+
+        Reviewed by Said Abou-Hallawa.
+
+        renderingUpdateScheduler() should be an implementation detail of Page.
+
+        Also add some explanatory comments.
+
+        * dom/Document.cpp:
+        (WebCore::Document::scheduleTimedRenderingUpdate):
+        * dom/ScriptedAnimationController.cpp:
+        (WebCore::ScriptedAnimationController::scheduleAnimation):
+        * page/Page.cpp:
+        (WebCore::Page::scheduleImmediateRenderingUpdate):
+        * page/Page.h:
+        * page/PageOverlayController.cpp:
+        (WebCore::PageOverlayController::didChangeViewExposedRect):
+        (WebCore::PageOverlayController::notifyFlushRequired):
+        * page/mac/ServicesOverlayController.mm:
+        (WebCore::ServicesOverlayController::Highlight::notifyFlushRequired):
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::layerTreeAsText):
+
 2020-09-25  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -7562 +7562 @@
 #endif
     if (auto page = this->page())
-        page->renderingUpdateScheduler().scheduleTimedRenderingUpdate();
+        page->scheduleTimedRenderingUpdate();
 }
 

trunk/Source/WebCore/dom/ScriptedAnimationController.cpp

@@ -182 +182 @@
 
     if (auto* page = this->page())
-        page->renderingUpdateScheduler().scheduleTimedRenderingUpdate();
+        page->scheduleTimedRenderingUpdate();
 }
 

trunk/Source/WebCore/page/Page.cpp

@@ -104 +104 @@
 #include "RenderView.h"
 #include "RenderWidget.h"
+#include "RenderingUpdateScheduler.h"
 #include "ResizeObserver.h"
 #include "ResourceUsageOverlay.h"
@@ -1422 +1423 @@
 }
 
+void Page::scheduleImmediateRenderingUpdate()
+{
+    renderingUpdateScheduler().scheduleImmediateRenderingUpdate();
+}
+
 void Page::startTrackingRenderingUpdates()
 {

trunk/Source/WebCore/page/Page.h

@@ -36 +36 @@
 #include "Region.h"
 #include "RegistrableDomain.h"
-#include "RenderingUpdateScheduler.h"
 #include "ScrollTypes.h"
 #include "ShouldRelaxThirdPartyCookieBlocking.h"
@@ -132 +131 @@
 class RenderObject;
 class ResourceUsageOverlay;
+class RenderingUpdateScheduler;
 class ScrollLatchingController;
 class ScrollingCoordinator;
@@ -267 +267 @@
     PerformanceMonitor* performanceMonitor() { return m_performanceMonitor.get(); }
 
-    RenderingUpdateScheduler& renderingUpdateScheduler();
-
     ValidationMessageClient* validationMessageClient() const { return m_validationMessageClient.get(); }
     void updateValidationBubbleStateIfNeeded();
@@ -493 +491 @@
     
     WEBCORE_EXPORT void finalizeRenderingUpdate(OptionSet<FinalizeRenderingUpdateFlags>);
-    
+
+    // Do immediate or timed update as dictated by the ChromeClient.
     WEBCORE_EXPORT void scheduleRenderingUpdate();
+    // Schedule an update that coordinates with display refresh; the normal kind of update.
     void scheduleTimedRenderingUpdate();
-    
+    // Schedule an update in the current runloop; this is an eager update that may trigger rendering more than once per display refresh.
+    void scheduleImmediateRenderingUpdate();
+
     WEBCORE_EXPORT void startTrackingRenderingUpdates();
     WEBCORE_EXPORT unsigned renderingUpdateCount() const;
@@ -814 +816 @@
 
     void doAfterUpdateRendering();
+
+    RenderingUpdateScheduler& renderingUpdateScheduler();
 
     WheelEventTestMonitor& ensureWheelEventTestMonitor();

trunk/Source/WebCore/page/PageOverlayController.cpp

@@ -319 +319 @@
 void PageOverlayController::didChangeViewExposedRect()
 {
-    m_page.renderingUpdateScheduler().scheduleTimedRenderingUpdate();
+    m_page.scheduleTimedRenderingUpdate();
 }
 
@@ -413 +413 @@
 void PageOverlayController::notifyFlushRequired(const GraphicsLayer*)
 {
-    m_page.renderingUpdateScheduler().scheduleTimedRenderingUpdate();
+    m_page.scheduleTimedRenderingUpdate();
 }
 

trunk/Source/WebCore/page/mac/ServicesOverlayController.mm

@@ -122 +122 @@
         return;
 
-    m_controller->page().renderingUpdateScheduler().scheduleTimedRenderingUpdate();
+    m_controller->page().scheduleTimedRenderingUpdate();
 }
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -2267 +2267 @@
 
     flushPendingLayerChanges(true);
-    page().renderingUpdateScheduler().scheduleImmediateRenderingUpdate();
+    page().scheduleImmediateRenderingUpdate();
 
     LayerTreeAsTextBehavior layerTreeBehavior = LayerTreeAsTextBehaviorNormal;