Changeset 267612 in webkit

Timestamp:

Sep 25, 2020, 5:27:09 PM (6 years ago)

Author:

timothy_horton@apple.com

Message:

Crunchyroll playback controls do not work on iPad with trackpad
​https://bugs.webkit.org/show_bug.cgi?id=217000
<rdar://problem/66362029>

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isCrunchyroll):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(applicationIsKnownToIgnoreMouseEvents):
Add it to the list.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/RuntimeApplicationChecks.h (modified) (1 diff)
• WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-25  Tim Horton  <timothy_horton@apple.com>
+
+        Crunchyroll playback controls do not work on iPad with trackpad
+        https://bugs.webkit.org/show_bug.cgi?id=217000
+        <rdar://problem/66362029>
+
+        Reviewed by Wenson Hsieh.
+
+        * platform/RuntimeApplicationChecks.h:
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::IOSApplication::isCrunchyroll):
+
 2020-09-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/RuntimeApplicationChecks.h

@@ -114 +114 @@
 WEBCORE_EXPORT bool isJWLibrary();
 WEBCORE_EXPORT bool isPaperIO();
+WEBCORE_EXPORT bool isCrunchyroll();
 
 } // IOSApplication

trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

@@ -435 +435 @@
 }
 
+bool IOSApplication::isCrunchyroll()
+{
+    static bool isCrunchyroll = applicationBundleIsEqualTo("com.crunchyroll.iphone"_s);
+    return isCrunchyroll;
+}
+
 #endif
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-25  Tim Horton  <timothy_horton@apple.com>
+
+        Crunchyroll playback controls do not work on iPad with trackpad
+        https://bugs.webkit.org/show_bug.cgi?id=217000
+        <rdar://problem/66362029>
+
+        Reviewed by Wenson Hsieh.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (applicationIsKnownToIgnoreMouseEvents):
+        Add it to the list.
+
 2020-09-25  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -8573 +8573 @@
             || WebCore::IOSApplication::isOKCupid() // <rdar://problem/65698496>
             || WebCore::IOSApplication::isJWLibrary() // <rdar://problem/68104852>
-            || WebCore::IOSApplication::isPaperIO()) { // <rdar://problem/68738585>
+            || WebCore::IOSApplication::isPaperIO() // <rdar://problem/68738585>
+            || WebCore::IOSApplication::isCrunchyroll()) { // <rdar://problem/66362029>
             warningVersion = "14.2";
             return YES;