Changeset 267620 in webkit

Timestamp:

Sep 26, 2020, 6:51:33 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue
​https://bugs.webkit.org/show_bug.cgi?id=149551

Reviewed by Michael Catanzaro.

The problem is that we are not including all the cookies in the web socket request. There are two cookies with
the Lax same-site policy set, that are not included for the websocket request.

• Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::webSocketConnectRequest): Add same site information to WebSocket requests.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/websockets/ThreadableWebSocketChannel.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue
+        https://bugs.webkit.org/show_bug.cgi?id=149551
+
+        Reviewed by Michael Catanzaro.
+
+        The problem is that we are not including all the cookies in the web socket request. There are two cookies with
+        the Lax same-site policy set, that are not included for the websocket request.
+
+        * Modules/websockets/ThreadableWebSocketChannel.cpp:
+        (WebCore::ThreadableWebSocketChannel::webSocketConnectRequest): Add same site information to WebSocket requests.
+
 2020-09-25  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp

@@ -34 +34 @@
 #include "ContentRuleListResults.h"
 #include "Document.h"
+#include "FrameLoader.h"
 #include "HTTPHeaderValues.h"
 #include "Page.h"
@@ -121 +122 @@
     request.setFirstPartyForCookies(document.firstPartyForCookies());
     request.setHTTPHeaderField(HTTPHeaderName::Origin, document.securityOrigin().toString());
+    FrameLoader::addSameSiteInfoToRequestIfNeeded(request, &document);
 
     // Add no-cache headers to avoid compatibility issue.