Changeset 267622 in webkit

Timestamp:

Sep 26, 2020, 7:14:13 AM (6 years ago)

Author:

Alan Bujtas

Message:

[LFC][IFC] Line content logical width expands with run expansions (text-align: justify)
​https://bugs.webkit.org/show_bug.cgi?id=217011

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/run-expansion-extends-line-content-width.html

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::applyRunExpansion):

LayoutTests:

• fast/layoutformattingcontext/run-expansion-extends-line-content-width-expected.html: Added.
• fast/layoutformattingcontext/run-expansion-extends-line-content-width.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/layoutformattingcontext/run-expansion-extends-line-content-width-expected.html (added)
• LayoutTests/fast/layoutformattingcontext/run-expansion-extends-line-content-width.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/layout/inlineformatting/InlineLine.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-26  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] Line content logical width expands with run expansions (text-align: justify)
+        https://bugs.webkit.org/show_bug.cgi?id=217011
+
+        Reviewed by Antti Koivisto.
+
+        * fast/layoutformattingcontext/run-expansion-extends-line-content-width-expected.html: Added.
+        * fast/layoutformattingcontext/run-expansion-extends-line-content-width.html: Added.
+
 2020-09-25  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-26  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] Line content logical width expands with run expansions (text-align: justify)
+        https://bugs.webkit.org/show_bug.cgi?id=217011
+
+        Reviewed by Antti Koivisto.
+
+        Test: fast/layoutformattingcontext/run-expansion-extends-line-content-width.html
+
+        * layout/inlineformatting/InlineLine.cpp:
+        (WebCore::Layout::Line::applyRunExpansion):
+
 2020-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp

@@ -112 +112 @@
         accumulatedExpansion += computedExpansion;
     }
+    // Content grows as runs expand.
+    m_contentLogicalWidth += accumulatedExpansion;
+    ASSERT(m_contentLogicalWidth == m_horizontalConstraint);
 }