⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 267652 in webkit


Ignore:
Timestamp:
Sep 27, 2020, 12:37:26 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Clean up type parameter for Event idl
​https://bugs.webkit.org/show_bug.cgi?id=217013

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-27
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update improved test result.

  • web-platform-tests/html/dom/idlharness.https-expected.txt:

Source/WebCore:

Clean up type parameter for Event idl files, there is no need to
pass "undefined" default value.

  • dom/CompositionEvent.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/UIEvent.idl:
  • storage/StorageEvent.idl:

LayoutTests:

Update improved test results.

  • platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
Location:
trunk
Files:
18 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r267645 r267652  
     12020-09-27  Rob Buis  <rbuis@igalia.com>
     2
     3        Clean up type parameter for Event idl
     4        https://bugs.webkit.org/show_bug.cgi?id=217013
     5
     6        Reviewed by Chris Dumez.
     7
     8        Update improved test results.
     9
     10        * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
     11        * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
     12        * platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
     13        * platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
     14        * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
     15
    1162020-09-26  Wenson Hsieh  <wenson_hsieh@apple.com>
    217

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r267651 r267652  
     12020-09-27  Rob Buis  <rbuis@igalia.com>
     2
     3        Clean up type parameter for Event idl
     4        https://bugs.webkit.org/show_bug.cgi?id=217013
     5
     6        Reviewed by Chris Dumez.
     7
     8        Update improved test result.
     9
     10        * web-platform-tests/html/dom/idlharness.https-expected.txt:
     11
    1122020-09-26  Darin Adler  <darin@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt

    r267646 r267652  
    48824882PASS StorageEvent interface: attribute url
    48834883PASS StorageEvent interface: attribute storageArea
    4884 FAIL StorageEvent interface: operation initStorageEvent(DOMString, boolean, boolean, DOMString, DOMString, DOMString, USVString, Storage) assert_equals: property has wrong .length expected 1 but got 0
     4884PASS StorageEvent interface: operation initStorageEvent(DOMString, boolean, boolean, DOMString, DOMString, DOMString, USVString, Storage)
    48854885PASS HTMLMarqueeElement interface: existence and properties of interface object
    48864886PASS HTMLMarqueeElement interface object length

  • trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt

    r267083 r267652  
    50555055PASS StorageEvent interface: attribute url
    50565056PASS StorageEvent interface: attribute storageArea
    5057 FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
     5057PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
    50585058PASS HTMLMarqueeElement interface: existence and properties of interface object
    50595059PASS HTMLMarqueeElement interface object length

  • trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt

    r267083 r267652  
    50455045PASS StorageEvent interface: attribute url
    50465046PASS StorageEvent interface: attribute storageArea
    5047 FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
     5047PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
    50485048PASS HTMLMarqueeElement interface: existence and properties of interface object
    50495049PASS HTMLMarqueeElement interface object length

  • trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt

    r266446 r267652  
    50555055PASS StorageEvent interface: attribute url
    50565056PASS StorageEvent interface: attribute storageArea
    5057 FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
     5057PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
    50585058PASS HTMLMarqueeElement interface: existence and properties of interface object
    50595059PASS HTMLMarqueeElement interface object length

  • trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt

    r267083 r267652  
    50555055PASS StorageEvent interface: attribute url
    50565056PASS StorageEvent interface: attribute storageArea
    5057 FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
     5057PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
    50585058PASS HTMLMarqueeElement interface: existence and properties of interface object
    50595059PASS HTMLMarqueeElement interface object length

  • trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt

    r267083 r267652  
    50555055PASS StorageEvent interface: attribute url
    50565056PASS StorageEvent interface: attribute storageArea
    5057 FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
     5057PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
    50585058PASS HTMLMarqueeElement interface: existence and properties of interface object
    50595059PASS HTMLMarqueeElement interface object length

  • trunk/Source/WebCore/ChangeLog

    r267648 r267652  
     12020-09-27  Rob Buis  <rbuis@igalia.com>
     2
     3        Clean up type parameter for Event idl
     4        https://bugs.webkit.org/show_bug.cgi?id=217013
     5
     6        Reviewed by Chris Dumez.
     7
     8        Clean up type parameter for Event idl files, there is no need to
     9        pass "undefined" default value.
     10
     11        * dom/CompositionEvent.idl:
     12        * dom/HashChangeEvent.idl:
     13        * dom/KeyboardEvent.idl:
     14        * dom/MouseEvent.idl:
     15        * dom/MutationEvent.idl:
     16        * dom/TextEvent.idl:
     17        * dom/TouchEvent.idl:
     18        * dom/UIEvent.idl:
     19        * storage/StorageEvent.idl:
     20
    1212020-09-26  Zalan Bujtas  <zalan@apple.com>
    222

  • trunk/Source/WebCore/dom/CompositionEvent.idl

    r266311 r267652  
    2929    readonly attribute DOMString data;
    3030
    31     // FIXME: Using "undefined" as default parameter value is wrong.
    32     undefined initCompositionEvent(optional DOMString typeArg = "undefined",
     31    undefined initCompositionEvent(DOMString typeArg,
    3332                              optional boolean canBubbleArg = false,
    3433                              optional boolean cancelableArg = false,

  • trunk/Source/WebCore/dom/HashChangeEvent.idl

    r266311 r267652  
    2222    constructor(DOMString type, optional HashChangeEventInit eventInitDict);
    2323
    24     // FIXME: Using "undefined" as default parameter value is wrong.
    25     undefined initHashChangeEvent(optional DOMString type = "undefined",
     24    undefined initHashChangeEvent(DOMString type,
    2625                             optional boolean canBubble = false,
    2726                             optional boolean cancelable = false,

  • trunk/Source/WebCore/dom/KeyboardEvent.idl

    r266311 r267652  
    5050
    5151    // FIXME: this does not match the version in the DOM spec.
    52     // FIXME: Using "undefined" as default parameter value is wrong.
    53     undefined initKeyboardEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false,
     52    undefined initKeyboardEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false,
    5453        optional WindowProxy? view = null, optional DOMString keyIdentifier = "undefined", optional unsigned long location = 0,
    5554        optional boolean ctrlKey = false, optional boolean altKey = false, optional boolean shiftKey = false, optional boolean metaKey = false, optional boolean altGraphKey = false);

  • trunk/Source/WebCore/dom/MouseEvent.idl

    r266311 r267652  
    4444    [Conditional=MOUSE_FORCE_EVENTS, ImplementedAs=force]readonly attribute double webkitForce;
    4545
    46     // FIXME: Using "undefined" as default parameter value is wrong.
    4746    // FIXME: relatedTarget should be of type EventTarget? but we need to use any to support a quirk for iAd Producer (rdar://problem/30640101).
    48     [CallWith=GlobalObject&ScriptExecutionContext, ImplementedAs=initMouseEventQuirk] undefined initMouseEvent(optional DOMString type = "undefined",
     47    [CallWith=GlobalObject&ScriptExecutionContext, ImplementedAs=initMouseEventQuirk] undefined initMouseEvent(DOMString type,
    4948        optional boolean canBubble = false, optional boolean cancelable = false,
    5049        optional WindowProxy? view = null, optional long detail = 0,

  • trunk/Source/WebCore/dom/MutationEvent.idl

    r266311 r267652  
    3030    readonly attribute unsigned short attrChange;
    3131
    32     // FIXME: Using "undefined" as default parameter value is wrong.
    33     undefined initMutationEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false,
     32    undefined initMutationEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false,
    3433        optional Node? relatedNode = null, optional DOMString prevValue = "undefined", optional DOMString newValue = "undefined",
    3534        optional DOMString attrName = "undefined", optional unsigned short attrChange = 0);

  • trunk/Source/WebCore/dom/TextEvent.idl

    r266311 r267652  
    2929    readonly attribute DOMString data;
    3030
    31     // FIXME: Using "undefined" as default parameter value is wrong.
    32     undefined initTextEvent(optional DOMString typeArg = "undefined",
     31    undefined initTextEvent(DOMString typeArg,
    3332                       optional boolean canBubbleArg = false,
    3433                       optional boolean cancelableArg = false,

  • trunk/Source/WebCore/dom/TouchEvent.idl

    r266649 r267652  
    3737    readonly attribute boolean metaKey;
    3838
    39     // FIXME: Using "undefined" as default parameter value is wrong.
    4039    undefined initTouchEvent(optional TouchList? touches = null,
    4140                        optional TouchList? targetTouches = null,
    4241                        optional TouchList? changedTouches = null,
    43                         optional DOMString type = "undefined",
     42                        optional DOMString type,
    4443                        optional WindowProxy? view = null,
    4544                        optional long screenX = 0,

  • trunk/Source/WebCore/dom/UIEvent.idl

    r266311 r267652  
    2424    readonly attribute long detail;
    2525   
    26     // FIXME: Using "undefined" as default parameter value is wrong.
    27     undefined initUIEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false, optional WindowProxy? view = null, optional long detail = 0);
     26    undefined initUIEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false, optional WindowProxy? view = null, optional long detail = 0);
    2827
    2928    readonly attribute long layerX;

  • trunk/Source/WebCore/storage/StorageEvent.idl

    r266311 r267652  
    3333    readonly attribute Storage? storageArea;
    3434
    35     // FIXME: Using "undefined" as default parameter value is wrong.
    36     undefined initStorageEvent(optional DOMString typeArg = "undefined",
     35    undefined initStorageEvent(DOMString typeArg,
    3736                          optional boolean canBubbleArg = false,
    3837                          optional boolean cancelableArg = false,
Note: See TracChangeset for help on using the changeset viewer.