Changeset 267668 in webkit

Timestamp:

Sep 27, 2020, 11:48:00 AM (6 years ago)

Author:

Darin Adler

Message:

Remove run-webkit-tests code that strips trailing spaces when comparing expected.txt files
​https://bugs.webkit.org/show_bug.cgi?id=217041

Reviewed by Sam Weinig.

• Scripts/webkitpy/port/base.py:

(Port.do_text_results_differ): Removed code to strip the expected text before comparing.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/base.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-27  Darin Adler  <darin@apple.com>
+
+        Remove run-webkit-tests code that strips trailing spaces when comparing expected.txt files
+        https://bugs.webkit.org/show_bug.cgi?id=217041
+
+        Reviewed by Sam Weinig.
+
+        * Scripts/webkitpy/port/base.py:
+        (Port.do_text_results_differ): Removed code to strip the expected text before comparing.
+
 2020-09-25  Darin Adler  <darin@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/base.py

@@ -301 +301 @@
 
     def do_text_results_differ(self, expected_text, actual_text):
-        # Ignore trailing spaces in expected files. We will remove this code after removing trailing spaces from all expected.txt files.
-        if not expected_text.startswith("<?xml"):
-            expected_text = re.compile(" +$", re.MULTILINE).sub("", expected_text)
         return expected_text != actual_text