Changeset 267676 in webkit

Timestamp:

Sep 27, 2020, 1:00:23 PM (6 years ago)

Author:

Alan Coon

Message:

Cherry-pick r267198. rdar://problem/69594065

[iOS] YouTube does not route video to AirPlay the first time
​https://bugs.webkit.org/show_bug.cgi?id=216626
<rdar://problem/62222846>

Reviewed by Eric Carlson.

Difficult to test this, since it requires an live AppleTV device.

During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
which explains the "only initial AirPlay fails" behavior.

• platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@267198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-610-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/ios/MediaSessionManagerIOS.mm (modified) (1 diff)

branches/safari-610-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-27  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r267198. rdar://problem/69594065
+
+    [iOS] YouTube does not route video to AirPlay the first time
+    https://bugs.webkit.org/show_bug.cgi?id=216626
+    <rdar://problem/62222846>
+    
+    Reviewed by Eric Carlson.
+    
+    Difficult to test this, since it requires an live AppleTV device.
+    
+    During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
+    be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
+    which explains the "only initial AirPlay fails" behavior.
+    
+    * platform/audio/ios/MediaSessionManagerIOS.mm:
+    (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-09-17  Jer Noble  <jer.noble@apple.com>
+
+            [iOS] YouTube does not route video to AirPlay the first time
+            https://bugs.webkit.org/show_bug.cgi?id=216626
+            <rdar://problem/62222846>
+
+            Reviewed by Eric Carlson.
+
+            Difficult to test this, since it requires an live AppleTV device.
+
+            During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
+            be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
+            which explains the "only initial AirPlay fails" behavior.
+
+            * platform/audio/ios/MediaSessionManagerIOS.mm:
+            (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):
+
 2020-09-27  Alan Coon  <alancoon@apple.com>
 

branches/safari-610-branch/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm

@@ -206 +206 @@
         return;
 
+    nowPlayingSession->setPlaybackTarget(WTFMove(playbackTarget));
     nowPlayingSession->setShouldPlayToPlaybackTarget(supportsAirPlayVideo == SupportsAirPlayVideo::Yes);
-    nowPlayingSession->setPlaybackTarget(WTFMove(playbackTarget));
 }