Changeset 267691 in webkit

Timestamp:

Sep 27, 2020, 9:39:28 PM (6 years ago)

Author:

Lauro Moura

Message:

REGRESSION(r267688) [GTK] Many compositing timeouts
​https://bugs.webkit.org/show_bug.cgi?id=217044

Reviewed by Darin Adler.

Especulative fix by adding missing finalize step to
updateRendering (or calling isolatedUpdateRendering).

Covered by existing tests.

• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState):
Call finalizeUpdateRendering.
(WebKit::DrawingAreaCoordinatedGraphics::display): Ditto.

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:

(WebKit::LayerTreeHost::flushAndRenderLayers): Call
isolatedUpdateRendering instead of updateRendering on the corePage().

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (modified) (2 diffs)
• WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-27  Lauro Moura  <lmoura@igalia.com>
+
+        REGRESSION(r267688) [GTK] Many compositing timeouts
+        https://bugs.webkit.org/show_bug.cgi?id=217044
+
+        Reviewed by Darin Adler.
+
+        Especulative fix by adding missing finalize step to
+        updateRendering (or calling isolatedUpdateRendering).
+
+        Covered by existing tests.
+
+        * WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+        (WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState):
+        Call finalizeUpdateRendering.
+        (WebKit::DrawingAreaCoordinatedGraphics::display): Ditto.
+        * WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:
+        (WebKit::LayerTreeHost::flushAndRenderLayers): Call
+        isolatedUpdateRendering instead of updateRendering on the corePage().
+
 2020-09-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp

@@ -415 +415 @@
         m_webPage.setSize(size);
         m_webPage.updateRendering();
+        m_webPage.finalizeRenderingUpdate({ });
         m_webPage.flushPendingEditorStateUpdate();
         m_webPage.scrollMainFrameIfNotAtMaxScrollPosition(scrollOffset);
@@ -752 +753 @@
 
     m_webPage.updateRendering();
+    m_webPage.finalizeRenderingUpdate({ });
     m_webPage.flushPendingEditorStateUpdate();
 

trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp

@@ -197 +197 @@
         return;
 
-    m_webPage.corePage()->updateRendering();
+    m_webPage.corePage()->isolatedUpdateRendering();
 
     if (!flushPendingLayerChanges())