Changeset 267724 in webkit

Timestamp:

Sep 28, 2020, 9:10:11 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

webkitfullscreenchange does not fire for shadow DOM elements
​https://bugs.webkit.org/show_bug.cgi?id=216607

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-09-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

This bug was caused by the webkitfullscreenchange event being fired
but without _composed_ flag set.

This patch fixed the bug by making it composed as defined as
the step 3-2 of ​https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps.
so that event listeners outside shadow tree could observe it.

Test: fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html

• dom/FullscreenManager.cpp:

(WebCore::FullscreenManager::dispatchFullscreenChangeOrErrorEvent):

LayoutTests:

Added a regression test for making an element inside a shadow tree full screen,
and listening to webkitfullscreenchange outside the shadow tree.

• fast/shadow-dom/fullscreen-in-shadow-event-should-propagate-expected.txt: Added.
• fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html: Added.
• platform/ios-wk2/TestExpectations:

Other testcases related to fullscreen API in fast/shadow-dom/ are also
disabled for ios-wk2.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/shadow-dom/fullscreen-in-shadow-event-should-propagate-expected.txt (added)
• LayoutTests/fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html (added)
• LayoutTests/platform/ios-wk2/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/FullscreenManager.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-28  Tetsuharu Ohzeki  <tetsuharu.ohzeki@gmail.com>
+
+        webkitfullscreenchange does not fire for shadow DOM elements
+        https://bugs.webkit.org/show_bug.cgi?id=216607
+
+        Reviewed by Ryosuke Niwa.
+
+        Added a regression test for making an element inside a shadow tree full screen,
+        and listening to `webkitfullscreenchange` outside the shadow tree.
+
+        * fast/shadow-dom/fullscreen-in-shadow-event-should-propagate-expected.txt: Added.
+        * fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html: Added.
+        * platform/ios-wk2/TestExpectations:
+        Other testcases related to fullscreen API in fast/shadow-dom/ are also
+        disabled for ios-wk2.
+
 2020-09-28  Devin Rousso  <drousso@apple.com>
 

trunk/LayoutTests/platform/ios-wk2/TestExpectations

@@ -1018 +1018 @@
 fast/dom/Window/post-message-user-action.html [ Skip ]
 fast/images/image-usemap-parsing.html [ Skip ]
+fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html [ Skip ]
 fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html [ Skip ]
 fast/shadow-dom/fullscreen-in-shadow-fullscreenElement.html [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-28  Tetsuharu Ohzeki  <tetsuharu.ohzeki@gmail.com>
+
+        webkitfullscreenchange does not fire for shadow DOM elements
+        https://bugs.webkit.org/show_bug.cgi?id=216607
+
+        Reviewed by Ryosuke Niwa.
+
+        This bug was caused by the `webkitfullscreenchange` event being fired
+        but without _composed_ flag set.
+
+        This patch fixed the bug by making it composed as defined as
+        the step 3-2 of https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps.
+        so that event listeners outside shadow tree could observe it.
+
+        Test: fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html
+
+        * dom/FullscreenManager.cpp:
+        (WebCore::FullscreenManager::dispatchFullscreenChangeOrErrorEvent):
+
 2020-09-28  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/dom/FullscreenManager.cpp

@@ -483 +483 @@
 void FullscreenManager::dispatchFullscreenChangeOrErrorEvent(Deque<RefPtr<Node>>& queue, const AtomString& eventName, bool shouldNotifyMediaElement)
 {
+    // Step 3 of https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps
     while (!queue.isEmpty()) {
         RefPtr<Node> node = queue.takeFirst();
@@ -502 +503 @@
         UNUSED_PARAM(shouldNotifyMediaElement);
 #endif
-        node->dispatchEvent(Event::create(eventName, Event::CanBubble::Yes, Event::IsCancelable::No));
+        node->dispatchEvent(Event::create(eventName, Event::CanBubble::Yes, Event::IsCancelable::No, Event::IsComposed::Yes));
     }
 }