Changeset 268000 in webkit

Timestamp:

Oct 5, 2020, 1:55:54 PM (6 years ago)

Author:

eocanha@igalia.com

Message:

[GTK][X11] WebProcess crash in WebCore::GLContextGLX::createPbufferContext() with NVidia proprietary drivers
​https://bugs.webkit.org/show_bug.cgi?id=217323

Reviewed by Adrian Perez de Castro.

The returnedElements variable might remain uninitialized if the glXChooseFBConfig()
function call fails, leading to execution of the wrong code branch later.

• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::createPbufferContext): Initialized the returnedElements variable.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/glx/GLContextGLX.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-05  Enrique Ocaña González  <eocanha@igalia.com>
+
+        [GTK][X11] WebProcess crash in WebCore::GLContextGLX::createPbufferContext() with NVidia proprietary drivers
+        https://bugs.webkit.org/show_bug.cgi?id=217323
+
+        Reviewed by Adrian Perez de Castro.
+
+        The returnedElements variable might remain uninitialized if the glXChooseFBConfig()
+        function call fails, leading to execution of the wrong code branch later.
+
+        * platform/graphics/glx/GLContextGLX.cpp:
+        (WebCore::GLContextGLX::createPbufferContext): Initialized the returnedElements variable.
+
 2020-10-05  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp

@@ -222 +222 @@
     };
 
-    int returnedElements;
+    int returnedElements = 0;
     Display* display = downcast<PlatformDisplayX11>(platformDisplay).native();
     XUniquePtr<GLXFBConfig> configs(glXChooseFBConfig(display, 0, fbConfigAttributes, &returnedElements));