Changeset 26830 in webkit

Timestamp:

Oct 20, 2007, 2:00:53 PM (17 years ago)

Author:

bdash

Message:

2007-10-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

Workaround for ​http://bugs.webkit.org/show_bug.cgi?id=15574
Bug 15574: Web Inspector doesn't work with the new Database feature

The executeSql callback is executed in the security domain of the web page that owns the database,
while the inspector's window object is in the callback functions scope chain. This is leading to a
security violation when the callback attempts to access "document". We can work around this by
ensuring that "document" can be found in the scope chain before the window object.

• page/inspector/DatabasePanel.js:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/DatabasePanel.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-10-20  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by Tim Hatcher.
+
+        Workaround for http://bugs.webkit.org/show_bug.cgi?id=15574
+        Bug 15574: Web Inspector doesn't work with the new Database feature
+
+        The executeSql callback is executed in the security domain of the web page that owns the database,
+        while the inspector's window object is in the callback functions scope chain.  This is leading to a
+        security violation when the callback attempts to access "document".  We can work around this by
+        ensuring that "document" can be found in the scope chain before the window object.
+
+        * page/inspector/DatabasePanel.js:
+
 2007-10-20  Darin Adler  <darin@apple.com>
 

trunk/WebCore/page/inspector/DatabasePanel.js

@@ -124 +124 @@
 }
 
-WebInspector.DatabasePanel.prototype = {
+// FIXME: The function and local variables are a workaround for http://bugs.webkit.org/show_bug.cgi?id=15574.
+WebInspector.DatabasePanel.prototype = (function() {
+var document = window.document;
+var Math = window.Math;
+return {
     show: function()
     {
@@ -507 +511 @@
     }
 }
+})();
 
 WebInspector.DatabasePanel.prototype.__proto__ = WebInspector.Panel.prototype;