Changeset 26840 in webkit


Ignore:
Timestamp:
Oct 20, 2007, 9:00:28 PM (17 years ago)
Author:
mitz
Message:

WebCore:

Reviewed by Dave Hyatt.

Test: fast/table/insert-before-anonymous-ancestors.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Rolled out r11579. I think whatever that change was supposed to accomplish has since been done in other places in the code.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/table/form-in-table-before-misnested-text-crash-css-expected.txt:
  • fast/table/form-in-table-before-misnested-text-crash-expected.txt:
  • fast/table/insert-before-anonymous-ancestors.html: Added.
  • fast/table/section-in-table-before-misnested-text-crash-css-expected.txt:
  • fast/table/section-in-table-before-misnested-text-crash-expected.txt:
  • platform/mac/fast/table/insert-before-anonymous-ancestors-expected.checksum: Added.
  • platform/mac/fast/table/insert-before-anonymous-ancestors-expected.png: Added.
  • platform/mac/fast/table/insert-before-anonymous-ancestors-expected.txt: Added.
Location:
trunk
Files:
4 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r26826 r26840  
     12007-10-20  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Dave Hyatt.
     4
     5        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=15208
     6          display:table causes the collapsed text to show at a different position when expanded
     7
     8        * fast/table/form-in-table-before-misnested-text-crash-css-expected.txt:
     9        * fast/table/form-in-table-before-misnested-text-crash-expected.txt:
     10        * fast/table/insert-before-anonymous-ancestors.html: Added.
     11        * fast/table/section-in-table-before-misnested-text-crash-css-expected.txt:
     12        * fast/table/section-in-table-before-misnested-text-crash-expected.txt:
     13        * platform/mac/fast/table/insert-before-anonymous-ancestors-expected.checksum: Added.
     14        * platform/mac/fast/table/insert-before-anonymous-ancestors-expected.png: Added.
     15        * platform/mac/fast/table/insert-before-anonymous-ancestors-expected.txt: Added.
     16
    1172007-10-20  Darin Adler  <darin@apple.com>
    218

  • trunk/LayoutTests/fast/table/form-in-table-before-misnested-text-crash-css-expected.txt

    r21687 r26840  
    220 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
    33QQQ
    4 xxx 
     4xxx
    55Whee
    66QQQ

  • trunk/LayoutTests/fast/table/form-in-table-before-misnested-text-crash-expected.txt

    r21687 r26840  
    220 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
    33QQQ
    4 xxx 
     4xxx
    55Whee
    66QQQ

  • trunk/LayoutTests/fast/table/section-in-table-before-misnested-text-crash-css-expected.txt

    r21687 r26840  
    11This test checks whether a particular odd arrangement of DOM nodes results in render tree consistency violations.
    2 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 xxx 
     20 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 xxx
    33Whee
    44QQQ

  • trunk/LayoutTests/fast/table/section-in-table-before-misnested-text-crash-expected.txt

    r21687 r26840  
    11This test checks whether a particular odd arrangement of DOM nodes results in render tree consistency violations.
    2 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 xxx 
     20 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 xxx
    33Whee
    44QQQ

  • trunk/WebCore/ChangeLog

    r26837 r26840  
     12007-10-20  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Dave Hyatt.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=15208
     6          display:table causes the collapsed text to show at a different position when expanded
     7
     8        Test: fast/table/insert-before-anonymous-ancestors.html
     9
     10        * rendering/RenderTable.cpp:
     11        (WebCore::RenderTable::addChild): Rolled out r11579. I think whatever
     12        that change was supposed to accomplish has since been done in other
     13        places in the code.
     14
    1152007-10-20  Mark Rowe  <mrowe@apple.com>
    216

  • trunk/WebCore/rendering/RenderTable.cpp

    r26583 r26840  
    192192
    193193    RenderObject* lastBox = beforeChild;
    194     RenderObject* nextToLastBox = beforeChild;
    195     while (lastBox && lastBox->parent()->isAnonymous() && !lastBox->isTableSection() && lastBox->style()->display() != TABLE_CAPTION) {
    196         nextToLastBox = lastBox;
     194    while (lastBox && lastBox->parent()->isAnonymous() && !lastBox->isTableSection() && lastBox->style()->display() != TABLE_CAPTION)
    197195        lastBox = lastBox->parent();
    198     }
    199196    if (lastBox && lastBox->isAnonymous() && !isAfterContent(lastBox)) {
    200         lastBox->addChild(child, nextToLastBox);
     197        lastBox->addChild(child, beforeChild);
    201198        return;
    202199    }
Note: See TracChangeset for help on using the changeset viewer.