Changeset 268712 in webkit

Timestamp:

Oct 19, 2020, 8:45:54 PM (6 years ago)

Author:

Simon Fraser

Message:

Fix crash in RenderLayerBacking::updateClippingStackLayerGeometry()
​https://bugs.webkit.org/show_bug.cgi?id=217940
<rdar://problem/70316952>

Reviewed by Tim Horton.

Crash data suggest that entry.clipData.clippingLayer (which is a WeakRef<RenderLayer>)
can be null, so check it.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateClippingStackLayerGeometry):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-19  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix crash in RenderLayerBacking::updateClippingStackLayerGeometry()
+        https://bugs.webkit.org/show_bug.cgi?id=217940
+        <rdar://problem/70316952>
+
+        Reviewed by Tim Horton.
+
+        Crash data suggest that entry.clipData.clippingLayer (which is a WeakRef<RenderLayer>)
+        can be null, so check it.
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateClippingStackLayerGeometry):
+
 2020-10-19  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -1903 +1903 @@
 
         if (entry.clipData.isOverflowScroll) {
-            ScrollOffset scrollOffset = entry.clipData.clippingLayer->scrollOffset();
+            ScrollOffset scrollOffset = entry.clipData.clippingLayer ? entry.clipData.clippingLayer->scrollOffset() : ScrollOffset();
 
             entry.clippingLayer->setBoundsOrigin(scrollOffset);