Changeset 268752 in webkit

Timestamp:

Oct 20, 2020, 12:13:22 PM (6 years ago)

Author:

aakash_jain@apple.com

Message:

Make report-non-inclusive-language ignore autoinstalled directories and certain file types
​https://bugs.webkit.org/show_bug.cgi?id=217972

Reviewed by Beth Dakin.

• Scripts/report-non-inclusive-language: startswith and endswith also takes a tuple of suffixes to

look for, reference: ​https://docs.python.org/3/library/stdtypes.html#str.endswith

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/report-non-inclusive-language (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-10-20  Aakash Jain  <aakash_jain@apple.com>
+
+        Make report-non-inclusive-language ignore autoinstalled directories and certain file types
+        https://bugs.webkit.org/show_bug.cgi?id=217972
+
+        Reviewed by Beth Dakin.
+
+        * Scripts/report-non-inclusive-language: startswith and endswith also takes a tuple of suffixes to
+        look for, reference: https://docs.python.org/3/library/stdtypes.html#str.endswith
+
 2020-10-20  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/report-non-inclusive-language

@@ -34 +34 @@
 #   Report third party sources separately from WebKit project files.
 #   Skip known examples on an exception list that we don't intend to fix.
-#   Replace special cases for ChangeLog, ".order", ".xcuserstate", ".git", ".svn"
-#   files with something smarter.
 
 # Hard-coded for now, could read these out of a file instead.
@@ -44 +42 @@
     [ "slave", "slave" ]
 ]
+
+IGNORE_DIRECTORIES = ['.svn', '.git', 'autoinstalled']
+IGNORE_FILES_STARTING_WITH = ('ChangeLog')
+IGNORE_FILES_ENDING_WITH = ('.log', '.order', '.pyc', '.swp', '.xcuserstate')
 
 parser = argparse.ArgumentParser(description='Report counts and locations of non-inclusive terms.')
@@ -57 +59 @@
 for subroot, directories, files in os.walk(root):
     prefix = subroot[len(root) + 1:]
-    if ".svn" in prefix:
-        continue
-    if ".git" in prefix:
+    if any(directory in prefix for directory in IGNORE_DIRECTORIES):
         continue
     for file in files:
-        if file.startswith("ChangeLog"):
+        if file.startswith(IGNORE_FILES_STARTING_WITH):
             continue
-        if file.endswith(".order"):
-            continue
-        if file.endswith(".xcuserstate"):
+        if file.endswith(IGNORE_FILES_ENDING_WITH):
             continue
         handle = open(os.path.join(subroot, file), "r")