Changeset 268761 in webkit

Timestamp:

Oct 20, 2020, 2:40:40 PM (6 years ago)

Author:

Jonathan Bedard

Message:

[webkitpy] Use allowlist and blocklist
​https://bugs.webkit.org/show_bug.cgi?id=217985
<rdar://problem/70499499>

Reviewed by Aakash Jain.

• Scripts/webkitpy/pylintrc:
• Scripts/webkitpy/style/checkers/cpp.py:

(check_namespace_indentation):

• Scripts/webkitpy/w3c/common.py:

(is_basename_skipped):

• flatpak/flatpakutils.py:

(WebkitFlatpak.setup_gstbuild):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/pylintrc (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp.py (modified) (1 diff)
• Scripts/webkitpy/w3c/common.py (modified) (1 diff)
• flatpak/flatpakutils.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-10-20  Jonathan Bedard  <jbedard@apple.com>
+
+        [webkitpy] Use allowlist and blocklist
+        https://bugs.webkit.org/show_bug.cgi?id=217985
+        <rdar://problem/70499499>
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/pylintrc:
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_namespace_indentation):
+        * Scripts/webkitpy/w3c/common.py:
+        (is_basename_skipped):
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.setup_gstbuild):
+
 2020-10-20  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/webkitpy/pylintrc

@@ -39 +39 @@
 profile=no
 
-# Add files or directories to the blacklist. They should be base names, not
+# Add files or directories to the blocklist. They should be base names, not
 # paths.
 ignore=CVS

trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -2485 +2485 @@
 
 
-# Enum declaration whitelist
+# Enum declaration allowlist
 _ALLOW_ALL_UPPERCASE_ENUM = ['JSTokenType']
 

trunk/Tools/Scripts/webkitpy/w3c/common.py

@@ -80 +80 @@
     """
     assert '/' not in basename
-    blacklist = [
+    blocklist = [
         'MANIFEST.json',    # MANIFEST.json is automatically regenerated.
         'OWNERS',           # https://crbug.com/584660 https://crbug.com/702283
         'reftest.list',     # https://crbug.com/582838
     ]
-    return (basename in blacklist
+    return (basename in blocklist
             or is_testharness_baseline(basename)
             or basename.startswith('.'))

trunk/Tools/flatpak/flatpakutils.py

@@ -616 +616 @@
         command = [os.path.join(gst_dir, 'gst-env.py'), '--builddir', gst_builddir, '--srcdir', gst_dir, "--only-environment"]
         gst_env = run_sanitized(command, gather_output=True)
-        whitelist = ("LD_LIBRARY_PATH", "PATH", "PKG_CONFIG_PATH")
+        allowlist = ("LD_LIBRARY_PATH", "PATH", "PKG_CONFIG_PATH")
         nopathlist = ("GST_DEBUG", "GST_VERSION", "GST_ENV")
         env = []
@@ -622 +622 @@
             tokens = line.split("=")
             var_name, contents = tokens[0], "=".join(tokens[1:])
-            if not var_name.startswith("GST_") and var_name not in whitelist:
+            if not var_name.startswith("GST_") and var_name not in allowlist:
                 continue
             if var_name not in nopathlist: