Changeset 268782 in webkit

Timestamp:

Oct 20, 2020, 8:33:03 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Release assert in ~Node due to render element of pseudo element not getting removed in time
​https://bugs.webkit.org/show_bug.cgi?id=217996

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2020-10-20
Reviewed by Ryosuke Niwa.

When attaching a shadow root to an element, remember to tear down renderers not only if
one exists on the element, but also if it uses display: contents.

• dom/Element.cpp:

(WebCore::Element::addShadowRoot):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-20  Julian Gonzalez  <julian_a_gonzalez@apple.com>
+
+        Release assert in ~Node due to render element of pseudo element not getting removed in time
+        https://bugs.webkit.org/show_bug.cgi?id=217996
+
+        Reviewed by Ryosuke Niwa.
+
+        When attaching a shadow root to an element, remember to tear down renderers not only if
+        one exists on the element, but also if it uses display: contents.
+
+        * dom/Element.cpp:
+        (WebCore::Element::addShadowRoot):
+
 2020-10-20  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -2301 +2301 @@
         WidgetHierarchyUpdatesSuspensionScope suspendWidgetHierarchyUpdates;
         ScriptDisallowedScope::InMainThread scriptDisallowedScope;
-        if (renderer())
+        if (renderer() || hasDisplayContents())
             RenderTreeUpdater::tearDownRenderers(*this);