Changeset 268786 in webkit

Timestamp:

Oct 20, 2020, 11:25:38 PM (6 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(r266074): Uncaught Exception: undefined is not an object (evaluating 'this._allListenersBreakpoint.disabled')
​https://bugs.webkit.org/show_bug.cgi?id=217992

Reviewed by Joseph Pecoraro.

r266074 changed it such that _allListenersBreakpoint doesn't always exist, so check that
it exists before getting a property from it.

• UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager.prototype.listenerBreakpointForEventName):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/DOMDebuggerManager.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-10-20  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r266074): Uncaught Exception: undefined is not an object (evaluating 'this._allListenersBreakpoint.disabled')
+        https://bugs.webkit.org/show_bug.cgi?id=217992
+
+        Reviewed by Joseph Pecoraro.
+
+        r266074 changed it such that `_allListenersBreakpoint` doesn't always exist, so check that
+        it exists before getting a property from it.
+
+        * UserInterface/Controllers/DOMDebuggerManager.js:
+        (WI.DOMDebuggerManager.prototype.listenerBreakpointForEventName):
+
 2020-10-20  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js

@@ -355 +355 @@
     listenerBreakpointForEventName(eventName)
     {
-        if (DOMDebuggerManager.supportsAllListenersBreakpoint() && !this._allListenersBreakpoint.disabled)
+        if (DOMDebuggerManager.supportsAllListenersBreakpoint() && this._allListenersBreakpoint && !this._allListenersBreakpoint.disabled)
             return this._allListenersBreakpoint;
         return this._listenerBreakpoints.find((breakpoint) => breakpoint.eventName === eventName) || null;