Changeset 268791 in webkit

Timestamp:

Oct 21, 2020, 4:32:10 AM (6 years ago)

Author:

youenn@apple.com

Message:

[iOS] Disable audio capture in the background for non Safari applications
​https://bugs.webkit.org/show_bug.cgi?id=217948
<rdar://problem/70241557>

Reviewed by Eric Carlson.

Source/WebCore:

We do not have good OS support when capturing audio in a WebProcess for a backgrounded application.
Until we have proper support, it seems best to mute audio capture when being backgrounded.
Manually tested.

• platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm:

(WebCore::RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange):

LayoutTests:

• platform/ios/mediastream/video-muted-in-background-tab.html:

By default, audio capture will be muted in WTR if page goes to background.
Update the test to explicitly request for audio capture to continue while in background.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-10-21  Youenn Fablet  <youenn@apple.com>
+
+        [iOS] Disable audio capture in the background for non Safari applications
+        https://bugs.webkit.org/show_bug.cgi?id=217948
+        <rdar://problem/70241557>
+
+        Reviewed by Eric Carlson.
+
+        * platform/ios/mediastream/video-muted-in-background-tab.html:
+        By default, audio capture will be muted in WTR if page goes to background.
+        Update the test to explicitly request for audio capture to continue while in background.
+
 2020-10-21  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html

@@ -43 +43 @@
 
             promise_test(async (t) => {
-                if (window.internals)
+                if (window.internals) {
+                    window.internals.setShouldInterruptAudioOnPageVisibilityChange(false);
                     window.internals.setPageVisibility(false);
+                }
                 assert_false(audioTrack.muted, "audio track is active");
                 assert_true(videoTrack.muted, "video track is muted");

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-21  Youenn Fablet  <youenn@apple.com>
+
+        [iOS] Disable audio capture in the background for non Safari applications
+        https://bugs.webkit.org/show_bug.cgi?id=217948
+        <rdar://problem/70241557>
+
+        Reviewed by Eric Carlson.
+
+        We do not have good OS support when capturing audio in a WebProcess for a backgrounded application.
+        Until we have proper support, it seems best to mute audio capture when being backgrounded.
+        Manually tested.
+
+        * platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm:
+        (WebCore::RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange):
+
 2020-10-21  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm

@@ -29 +29 @@
 #if ENABLE(MEDIA_STREAM)
 
+#include "RuntimeApplicationChecks.h"
+
 namespace WebCore {
 
@@ -34 +36 @@
 {
 #if PLATFORM(IOS)
+    if (!WebCore::IOSApplication::isMobileSafari() && !WebCore::IOSApplication::isSafariViewService())
+        return true;
+
     NSArray *modes = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"UIBackgroundModes"];
     if (!modes)