Changeset 268797 in webkit

Timestamp:

Oct 21, 2020, 9:15:56 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Un-needed casts in Screen::{width,height}()
​https://bugs.webkit.org/show_bug.cgi?id=218013

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-10-21
Reviewed by Darin Adler.

• page/Screen.cpp:

(WebCore::Screen::height const): There is no need to convert from float to long and then
unsigned.
(WebCore::Screen::width const): Ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Screen.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-21  Philippe Normand  <pnormand@igalia.com>
+
+        Un-needed casts in Screen::{width,height}()
+        https://bugs.webkit.org/show_bug.cgi?id=218013
+
+        Reviewed by Darin Adler.
+
+        * page/Screen.cpp:
+        (WebCore::Screen::height const): There is no need to convert from float to long and then
+        unsigned.
+        (WebCore::Screen::width const): Ditto.
+
 2020-10-20  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/page/Screen.cpp

@@ -58 +58 @@
     if (RuntimeEnabledFeatures::sharedFeatures().webAPIStatisticsEnabled())
         ResourceLoadObserver::shared().logScreenAPIAccessed(*frame->document(), ResourceLoadStatistics::ScreenAPI::Height);
-    long height = static_cast<long>(frame->screenSize().height());
-    return static_cast<unsigned>(height);
+    return static_cast<unsigned>(frame->screenSize().height());
 }
 
@@ -69 +68 @@
     if (RuntimeEnabledFeatures::sharedFeatures().webAPIStatisticsEnabled())
         ResourceLoadObserver::shared().logScreenAPIAccessed(*frame->document(), ResourceLoadStatistics::ScreenAPI::Width);
-    long width = static_cast<long>(frame->screenSize().width());
-    return static_cast<unsigned>(width);
+    return static_cast<unsigned>(frame->screenSize().width());
 }