Changeset 268807 in webkit

Timestamp:

Oct 21, 2020, 11:07:34 AM (6 years ago)

Author:

graouts@webkit.org

Message:

[WK1] webanimations/accelerated-overlapping-transform-animations.html is a failure
​https://bugs.webkit.org/show_bug.cgi?id=217997
<rdar://problem/70505533>

Reviewed by Dean Jackson.

On WK1 UIHelper.ensureStablePresentationUpdate() does not guarantee frames have elapsed so we
wait a couple of animation frames in that configuration to ensure an accelerated animation has
been applied.

• platform/mac-wk1/TestExpectations:
• webanimations/accelerated-overlapping-transform-animations.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac-wk1/TestExpectations (modified) (1 diff)
• webanimations/accelerated-overlapping-transform-animations.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-10-21  Antoine Quint  <graouts@webkit.org>
+
+        [WK1] webanimations/accelerated-overlapping-transform-animations.html is a failure
+        https://bugs.webkit.org/show_bug.cgi?id=217997
+        <rdar://problem/70505533>
+
+        Reviewed by Dean Jackson.
+
+        On WK1 UIHelper.ensureStablePresentationUpdate() does not guarantee frames have elapsed so we
+        wait a couple of animation frames in that configuration to ensure an accelerated animation has
+        been applied.
+
+        * platform/mac-wk1/TestExpectations:
+        * webanimations/accelerated-overlapping-transform-animations.html:
+
 2020-10-21  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/platform/mac-wk1/TestExpectations

@@ -1199 +1199 @@
 
 webkit.org/b/217934 inspector/debugger/breakpoint-resolve-when-script-added.html [ Skip ]
-
-webkit.org/b/217997 webanimations/accelerated-overlapping-transform-animations.html [ Pass Failure ]

trunk/LayoutTests/webanimations/accelerated-overlapping-transform-animations.html

@@ -15 +15 @@
 <script>
 
+const waitForAnimationCommit = async (animation) => {
+    await animation.ready;
+    if (!UIHelper.isWebKit2()) {
+        await UIHelper.renderingUpdate();
+        await UIHelper.renderingUpdate();
+    } else
+        await UIHelper.ensureStablePresentationUpdate()
+}
+
 (async () => {
     if (window.testRunner)
@@ -24 +33 @@
     const duration = 60 * 1000;
 
-    // Start a first stationary "transform" animation.
-    const firstAnimation = target.animate({ transform: ["translateX(100px)", "translateX(100px)"] }, duration);
-
-    // Wait until this first animation has been applied.
-    await firstAnimation.ready;
-    await UIHelper.ensureStablePresentationUpdate();
-
-    // Now start a second stationary "transform" animation, which should replace the previous animation.
-    const secondAnimation = target.animate({ transform: ["translateX(200px)", "translateX(200px)"] }, duration);
-
-    // Wait until this second animation has been applied.
-    await secondAnimation.ready;
-    await UIHelper.ensureStablePresentationUpdate();
+    // Start a first stationary "transform" animation and wait until it has been applied before starting
+    // a second stationary "transform" animation which should replace the first one.
+    await waitForAnimationCommit(target.animate({ transform: ["translateX(100px)", "translateX(100px)"] }, duration));
+    await waitForAnimationCommit(target.animate({ transform: ["translateX(200px)", "translateX(200px)"] }, duration));
 
     if (window.testRunner)