Changeset 268817 in webkit

Timestamp:

Oct 21, 2020, 12:29:59 PM (6 years ago)

Author:

Alan Bujtas

Message:

[LFC][Integration] Remove redundant vertical position snapping in the iterator interface
​https://bugs.webkit.org/show_bug.cgi?id=218039

Reviewed by Antti Koivisto.

Snapping is done during display content construction.

• layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::rect const):
(WebCore::LayoutIntegration::verticallyRoundedRect): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationRunIteratorModernPath.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-21  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Integration] Remove redundant vertical position snapping in the iterator interface
+        https://bugs.webkit.org/show_bug.cgi?id=218039
+
+        Reviewed by Antti Koivisto.
+
+        Snapping is done during display content construction.
+
+        * layout/integration/LayoutIntegrationRunIteratorModernPath.h:
+        (WebCore::LayoutIntegration::RunIteratorModernPath::rect const):
+        (WebCore::LayoutIntegration::verticallyRoundedRect): Deleted.
+
 2020-10-21  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h

@@ -35 +35 @@
 namespace LayoutIntegration {
 
-inline FloatRect verticallyRoundedRect(const FloatRect& rect)
-{
-    return { FloatPoint(rect.x(), roundf(rect.y())), rect.size() };
-}
-
 class RunIteratorModernPath {
 public:
@@ -55 +50 @@
     bool isText() const { return !!run().textContent(); }
 
-    FloatRect rect() const { return verticallyRoundedRect(run().rect()); }
+    FloatRect rect() const { return run().rect(); }
 
     bool isHorizontal() const { return true; }